Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: components/pdf/renderer/ppb_pdf_impl.h

Issue 505243003: pdf: Move PepperPDFHost into the pdf component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pdf-component
Patch Set: tot-merge Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/pdf/renderer/pepper_pdf_host.cc ('k') | components/pdf/renderer/ppb_pdf_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/pdf/renderer/ppb_pdf_impl.h
diff --git a/components/pdf/renderer/ppb_pdf_impl.h b/components/pdf/renderer/ppb_pdf_impl.h
index 2cd5a44199e5f64c409b173b3d61d06a18c7b70e..5feeee3b94e0a3c4b3894e8a2fac0a0696be9896 100644
--- a/components/pdf/renderer/ppb_pdf_impl.h
+++ b/components/pdf/renderer/ppb_pdf_impl.h
@@ -22,8 +22,8 @@ class PPB_PDF_Impl {
virtual bool IsPrintingEnabled(PP_Instance instance_id) = 0;
// Invokes the "Print" command for the plugin instance identified by
- // |instance_id|.
- virtual void Print(PP_Instance instance_id) = 0;
+ // |instance_id|. Returns whether the "Print" command was issued or not.
+ virtual bool Print(PP_Instance instance_id) = 0;
};
// Returns a pointer to the interface implementing PPB_PDF that is exposed
@@ -31,8 +31,9 @@ class PPB_PDF_Impl {
static const PPB_PDF* GetInterface();
// Invokes the "Print" command for the given instance as if the user right
- // clicked on it and selected "Print".
- static void InvokePrintingForInstance(PP_Instance instance);
+ // clicked on it and selected "Print". Returns if the "Print" command was
+ // issued or not.
+ static bool InvokePrintingForInstance(PP_Instance instance);
// The caller retains the ownership of |print_client|. The client is
// allowed to be set only once, and when set, the client must outlive the
« no previous file with comments | « components/pdf/renderer/pepper_pdf_host.cc ('k') | components/pdf/renderer/ppb_pdf_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698