Add UMA to study the video types for mobile

content/browser/media/android/browser_media_player_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/media/android/browser_media_player_manager.h"
 
 #include "base/android/scoped_java_ref.h"
 #include "base/command_line.h"
+#include "base/metrics/histogram.h"
 #include "content/browser/android/content_view_core_impl.h"
 #include "content/browser/media/android/browser_demuxer_android.h"
 #include "content/browser/media/android/media_resource_getter_impl.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/web_contents/web_contents_view_android.h"
 #include "content/common/media/media_player_messages_android.h"
 #include "content/public/browser/android/content_view_core.h"
 #include "content/public/browser/android/external_video_surface_container.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/content_browser_client.h"
@@ skipping 14 matching lines @@
 using media::MediaPlayerBridge;
 using media::MediaPlayerManager;
 using media::MediaSourcePlayer;
 
 namespace content {
 
 // Threshold on the number of media players per renderer before we start
 // attempting to release inactive media players.
 const int kMediaPlayerThreshold = 1;
 
+// Number of media types to be recorded.
+const int kMaxMediaTypes = 2;

[Ilya Sherman, 2014/08/27 22:14:37]

nit: This is now unused.

[qinmin, 2014/08/28 00:30:09]

changed to 3 as we combine the 3 types.
On 2014/08/27 22:14:37, Ilya Sherman wrote:

+
 static BrowserMediaPlayerManager::Factory g_factory = NULL;
 static media::MediaUrlInterceptor* media_url_interceptor_ = NULL;
 
+void RecordMobileMediaType(bool is_media_url) {

[xhwang, 2014/08/27 23:02:21]

nit: Won't it be easier if you just report MediaPlayerHostMsg_Initialize_Type to
UMA (instead of using a boolean, which is harder to understand)?

[qinmin, 2014/08/28 00:30:09]

Done.

+  UMA_HISTOGRAM_BOOLEAN("Media.Mobile.MediaType", is_media_url);

[xhwang, 2014/08/27 23:02:21]

nit: Since this only applies to Chrome for Android (not Chrome for IOS), I
wonder whether "Mobile" is the correct term. How about s/Mobile/Android?

[qinmin, 2014/08/28 00:30:09]

Done.

+}
+
 // static
 void BrowserMediaPlayerManager::RegisterFactory(Factory factory) {
   g_factory = factory;
 }
 
 // static
 void BrowserMediaPlayerManager::RegisterMediaUrlInterceptor(
     media::MediaUrlInterceptor* media_url_interceptor) {
   media_url_interceptor_ = media_url_interceptor;
 }
@@ skipping 40 matching lines @@
         // May reach here due to prerendering. Don't extract the metadata
         // since it is expensive.
         // TODO(qinmin): extract the metadata once the user decided to load
         // the page.
         browser_media_player_manager->OnMediaMetadataChanged(
             media_player_params.player_id, base::TimeDelta(), 0, 0, false);
       } else if (!content_view_core_impl->ShouldBlockMediaRequest(
             media_player_params.url)) {
         media_player_bridge->Initialize();
       }
+      std::string path = media_player_params.url.path();
+      bool is_hls_media = EndsWith(path, ".m3u8", true) ||
+          EndsWith(path, ".m3u", true);
+      UMA_HISTOGRAM_BOOLEAN("Media.Mobile.IsHttpLiveStreamingMedia",
+                            is_hls_media);

[xhwang, 2014/08/27 23:02:21]

nit:

Since both UMAs are pretty small (having only two entries), probably we could
have just one UMA for all, which has:
URL_NON_HLS
URL_HLS
MEDIA_SOURCE

Then we have one central place to show the media type on Android. WDYT?

[qinmin, 2014/08/28 00:30:09]

Done.

[ddorwin, 2014/08/28 00:59:14]

drive-by:
Would it make more sense to have a "container" UMA or add HLS to an existing
one? I think we already have an MSE vs. normal UMA on desktop.

+      RecordMobileMediaType(true);
       return media_player_bridge;
     }
 
     case MEDIA_PLAYER_TYPE_MEDIA_SOURCE: {
+      RecordMobileMediaType(false);
       return new MediaSourcePlayer(
           media_player_params.player_id,
           manager,
           base::Bind(&BrowserMediaPlayerManager::OnMediaResourcesRequested,
                      weak_ptr_factory_.GetWeakPtr()),
           base::Bind(&BrowserMediaPlayerManager::OnMediaResourcesReleased,
                      weak_ptr_factory_.GetWeakPtr()),
           demuxer->CreateDemuxer(media_player_params.demuxer_client_id),
           media_player_params.frame_url);
     }
@@ skipping 466 matching lines @@
 #if defined(VIDEO_HOLE)
   MediaPlayerAndroid* player = GetPlayer(player_id);
   if (player && player->IsSurfaceInUse())
     return;
   if (external_video_surface_container_)
     external_video_surface_container_->ReleaseExternalVideoSurface(player_id);
 #endif  // defined(VIDEO_HOLE)
 }
 
 }  // namespace content