Add UMA to study the video types for mobile

content/browser/media/android/browser_media_player_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/media/android/browser_media_player_manager.h"
 
 #include "base/android/scoped_java_ref.h"
 #include "base/command_line.h"
+#include "base/metrics/histogram.h"
 #include "content/browser/android/content_view_core_impl.h"
 #include "content/browser/media/android/browser_demuxer_android.h"
 #include "content/browser/media/android/media_resource_getter_impl.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/web_contents/web_contents_view_android.h"
 #include "content/common/media/media_player_messages_android.h"
 #include "content/public/browser/android/content_view_core.h"
 #include "content/public/browser/android/external_video_surface_container.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/content_browser_client.h"
@@ skipping 77 matching lines @@
         // May reach here due to prerendering. Don't extract the metadata
         // since it is expensive.
         // TODO(qinmin): extract the metadata once the user decided to load
         // the page.
         browser_media_player_manager->OnMediaMetadataChanged(
             media_player_params.player_id, base::TimeDelta(), 0, 0, false);
       } else if (!content_view_core_impl->ShouldBlockMediaRequest(
             media_player_params.url)) {
         media_player_bridge->Initialize();
       }
+      std::string path = media_player_params.url.path();
+      if (EndsWith(path, ".m3u8", true) || EndsWith(path, ".m3u", true)) {
+        UMA_HISTOGRAM_BOOLEAN("MobileVideo.IsVideoUrlHLSVideo", true);
+      } else {
+        UMA_HISTOGRAM_BOOLEAN("MobileVideo.IsVideoUrlHLSVideo", false);

[Ilya Sherman, 2014/08/26 19:54:28]

nit: Please write this as

bool is_hls_video = EndsWith(path, ".m3u8", true) || EndsWith(path, ".m3u",
true);
UMA_HISTOGRAM_BOOLEAN("MobileVideo.IsVideoUrlHLSVideo", is_hls_video);

[qinmin, 2014/08/27 00:10:00]

Done.

+      }
+      UMA_HISTOGRAM_BOOLEAN("MobileVideo.IsRegularVideoUrl", true);
       return media_player_bridge;
     }
 
     case MEDIA_PLAYER_TYPE_MEDIA_SOURCE: {
+      UMA_HISTOGRAM_BOOLEAN("MobileVideo.IsRegularVideoUrl", false);

[Ilya Sherman, 2014/08/26 19:54:29]

nit: It's generally best to avoid repeating UMA_HISTOGRAM macros for a single
histogram, to reduce the likelihood of having a typo in just one of the code
paths.  I'd suggest creating a tiny wrapper function to which you pass |true| or
|false| to be emitted to the histogram.

[qinmin, 2014/08/27 00:10:00]

Done.

       return new MediaSourcePlayer(
           media_player_params.player_id,
           manager,
           base::Bind(&BrowserMediaPlayerManager::OnMediaResourcesRequested,
                      weak_ptr_factory_.GetWeakPtr()),
           base::Bind(&BrowserMediaPlayerManager::OnMediaResourcesReleased,
                      weak_ptr_factory_.GetWeakPtr()),
           demuxer->CreateDemuxer(media_player_params.demuxer_client_id),
           media_player_params.frame_url);
     }
@@ skipping 466 matching lines @@
 #if defined(VIDEO_HOLE)
   MediaPlayerAndroid* player = GetPlayer(player_id);
   if (player && player->IsSurfaceInUse())
     return;
   if (external_video_surface_container_)
     external_video_surface_container_->ReleaseExternalVideoSurface(player_id);
 #endif  // defined(VIDEO_HOLE)
 }
 
 }  // namespace content