Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: trunk/src/chrome/common/extensions/permissions/permissions_data.cc

Issue 50523011: Revert 231504 "Make app APIs implicit within _api_features.json ..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/common/extensions/permissions/permissions_data.cc
===================================================================
--- trunk/src/chrome/common/extensions/permissions/permissions_data.cc (revision 231915)
+++ trunk/src/chrome/common/extensions/permissions/permissions_data.cc (working copy)
@@ -579,6 +579,18 @@
return false;
}
+ // TODO(jeremya/kalman) do this via the features system by exposing the
+ // app.window API to platform apps, with no dependency on any permissions.
+ // See http://crbug.com/120069.
+ if (extension->is_platform_app()) {
+ initial_required_permissions_->api_permissions.insert(
+ APIPermission::kAppCurrentWindowInternal);
+ initial_required_permissions_->api_permissions.insert(
+ APIPermission::kAppRuntime);
+ initial_required_permissions_->api_permissions.insert(
+ APIPermission::kAppWindow);
+ }
+
initial_optional_permissions_.reset(new InitialPermissions);
if (!ParseHelper(extension,
keys::kOptionalPermissions,

Powered by Google App Engine
This is Rietveld 408576698