Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 50523004: Little changes to SkAnnotation in pipe: (Closed)

Created:
7 years, 1 month ago by mtklein
Modified:
7 years, 1 month ago
Reviewers:
scroggo, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Little changes to SkAnnotation in pipe: - store size in the op data field rather than separately (saves 4 bytes); - trim out a malloc/memcpy in each of read and write; - remove unused enum value; - use the right _unpackOp function; - make sure we call needOpBytes(). BUG= Committed: http://code.google.com/p/skia/source/detail?r=12007

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -17 lines) Patch
M src/pipe/SkGPipePriv.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/pipe/SkGPipeRead.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 1 chunk +8 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
Little things I noticed while debugging skia:1761. The only important one is making sure we ...
7 years, 1 month ago (2013-10-29 19:22:14 UTC) #1
scroggo
On 2013/10/29 19:22:14, mtklein wrote: > Little things I noticed while debugging skia:1761. The only ...
7 years, 1 month ago (2013-10-29 19:26:03 UTC) #2
reed1
lgtm
7 years, 1 month ago (2013-10-29 19:45:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/50523004/1
7 years, 1 month ago (2013-10-29 20:18:47 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-10-29 20:29:41 UTC) #5
Message was sent while issue was closed.
Change committed as 12007

Powered by Google App Engine
This is Rietveld 408576698