Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 505203003: Remove implicit conversions from scoped_refptr to T* in components/component_updater/ (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
Sorin Jianu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in components/component_updater/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Committed: https://crrev.com/6092f83c16504d6d31d356769a9f0688c54aca6c Cr-Commit-Position: refs/heads/master@{#292198}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/component_updater/component_patcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/component_updater/default_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + sorin@chromium.org
6 years, 3 months ago (2014-08-26 16:20:54 UTC) #1
dcheng
Unfortunately, we can't make scoped_refptr testable until the conversion operator has been removed. While it ...
6 years, 3 months ago (2014-08-26 16:20:54 UTC) #2
Sorin Jianu
lgtm Thank you Daniel!
6 years, 3 months ago (2014-08-27 17:24:36 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-27 17:37:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/505203003/1
6 years, 3 months ago (2014-08-27 17:38:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as adda0a4d202c6445ffc97ca59c8c5a55411c94f2
6 years, 3 months ago (2014-08-27 18:57:31 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:53:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6092f83c16504d6d31d356769a9f0688c54aca6c
Cr-Commit-Position: refs/heads/master@{#292198}

Powered by Google App Engine
This is Rietveld 408576698