Issue 505153003: Fix overflow when comparing two ints by promoting the sum to 64-bits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 505153003: Fix overflow when comparing two ints by promoting the sum to 64-bits. (Closed)

Created:
6 years, 3 months ago by djsollen

Modified:
6 years, 3 months ago

Reviewers:
scroggo, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Fix overflow when comparing two ints by promoting the sum to 64-bits. Committed: https://skia.googlesource.com/skia/+/97b49478cfbcdb9cac6de2ab0d44f975311ef631

Patch Set 2 : comment #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/images/SkImageDecoder_libico.cpp	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

djsollen

djsollen@google.com changed reviewers: + reed@google.com, scroggo@google.com

6 years, 3 months ago (2014-08-26 14:31:18 UTC) #1

reed1

lgtm w/ comment suggestion https://codereview.chromium.org/505153003/diff/1/src/images/SkImageDecoder_libico.cpp File src/images/SkImageDecoder_libico.cpp (right): https://codereview.chromium.org/505153003/diff/1/src/images/SkImageDecoder_libico.cpp#newcode157 src/images/SkImageDecoder_libico.cpp:157: if (((uint64_t)offset + size) > ...

6 years, 3 months ago (2014-08-26 14:48:23 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/505153003/20001

6 years, 3 months ago (2014-08-26 15:24:31 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-08-26 15:31:28 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (20001) as 97b49478cfbcdb9cac6de2ab0d44f975311ef631

Expand Messages | Collapse Messages

Issue 505153003: Fix overflow when comparing two ints by promoting the sum to 64-bits. (Closed)

Description

Patch Set 1 #

Patch Set 2 : comment #

Messages