WebRTC: Remove android_apk recipe

WebRTC: Remove android_apk recipe

This merges the android_apk into the standalone recipe since
it's become possible to build the Android APK tests from a standalone
checkout with https://review.webrtc.org/22149004/

Building from a standalone checkout also means we automatically gets
http://crbug.com/402594 fixed.
I changed the package/extract build revision passing a
little for both standalone and chromium recipe, which
will hopefully fix both http://crbug.com/407311
and http://crbug.com/385092 as well.

This makes it possible to remove the base_android recipe module
since it was only used by WebRTC anyway.

The scripts/slave/patch_path_filter.py script is also removed, since
there's no need for filtering of patches like these trybots needed.
Along with that, the third_party/depot_tools_patch copy is no longer needed.

Summary of master builder changes:

client.webrtc:
Renames:
* Android -> Android Builder
* Android (dbg) -> Android Builder (dbg)
* Android Chromium-APK Tests bots gets "Chromium-APK" removed from their name.
Removed:
* Android Chromium-APK Builder
* Android Chromium-APK Builder (dbg)

tryserver.webrtc:
Got APK tests added to their steps (previously only compiled): 
* android
* android_rel
Removed:
* android_apk
* android_apk_rel

BUG=webrtc:3741, 402594, 407311, 385092
TESTED=
Regular build and test of client.webrtc:
scripts/tools/run_recipe.py webrtc/standalone buildername="Android Builder" mastername=client.webrtc slavename=x revision='"6973"' 
scripts/tools/run_recipe.py webrtc/standalone buildername="Android Tests (KK Nexus5)" mastername=client.webrtc slavename=x revision='"6973"' 

Trybot run of tryserver.webrtc:
scripts/tools/run_recipe.py webrtc/standalone buildername="android" mastername=tryserver.webrtc slavename=x revision='"6973"' patchset=1 issue=22149004 rietveld=https://webrtc-codereview.appspot.com

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291753

[kjellander_chromium, 2014-08-26 13:52:31]

kjellander@chromium.org changed reviewers:
+ iannucci@chromium.org, machenbach@chromium.org

[kjellander_chromium, 2014-08-26 13:52:31]

Sorry for the huge review. I thought it would be quite tricky to do this in
multiple steps since I need to commit
https://webrtc-codereview.appspot.com/22149004/ at approximately the same time
without breaking too many things.

[kjellander_chromium, 2014-08-27 14:32:59]

During local testing I found that the root directory is calculated by relative
path traversal in the Android toolchain for test execution. I had to make
https://codereview.chromium.org/500423004/ to workaround this, thus PS#2 was
needed in order to pass the environment variable.

I also moved the logic of the locations of .isolate files into the recipe
module, so we can avoid depending on landing CLs in Chromium when we add/move
any of our Android tests.

https://codereview.chromium.org/505153002/diff/20001/scripts/slave/recipes/we...
File scripts/slave/recipes/webrtc/chromium.py (right):

https://codereview.chromium.org/505153002/diff/20001/scripts/slave/recipes/we...
scripts/slave/recipes/webrtc/chromium.py:92: archive_revision =
api.properties.get('parent_got_revision', got_revision)
I believe I'm fixing http://crbug.com/407311 with this. I did the same changes
in the standalone recipe, so I decided to include it here as well since they use
the same moved code in the webrtc recipe module (the check for a forced tester
resulting in an error message).

https://codereview.chromium.org/505153002/diff/20001/scripts/slave/recipes/we...
File
scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android_tests__jb_nexus7_2_.json
(left):

https://codereview.chromium.org/505153002/diff/20001/scripts/slave/recipes/we...
scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android_tests__jb_nexus7_2_.json:97:
"GYP_DEFINES": "OS=android component=static_library fastbuild=1
gomadir='[BUILD]/goma' include_tests=1 target_arch=arm use_goma=1",
include_tests=1 is no longer needed, it was a flag that normally was 0 for
chromium builds to avoid building WebRTC tests in Chromium.
For WebRTC standalone builds, the default value is 1.

[kjellander_chromium, 2014-08-29 09:33:16]

kjellander@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[kjellander_chromium, 2014-08-29 09:33:16]

phajdan: feel free to take a stab at this. I'd really like to get this going as
it allows me to throw away so much code.

If you guys really want me to split this up in a multi-step rocket - let me
know.

[Paweł Hajdan Jr., 2014-08-29 09:54:23]

LGTM

[kjellander_chromium, 2014-08-29 11:05:59]

Patchset #3 (id:40001) has been deleted

[kjellander_chromium, 2014-09-01 11:07:06]

The CQ bit was checked by kjellander@chromium.org

[commit-bot: I haz the power, 2014-09-01 11:07:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kjellander@chromium.org/505153002/60001

[commit-bot: I haz the power, 2014-09-01 11:09:16]

Committed patchset #3 (id:60001) as 291753