Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 505143002: Make Reset Settings section not be hidden by default. (Closed)

Created:
6 years, 3 months ago by Mike Lerman
Modified:
6 years, 3 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make Reset Settings section not be hidden by default. The Reset Settings section in Advanced Settings used to be hidden by default, and then enabled if the profile was OffTheRecord. CL https://codereview.chromium.org/467363003 changed this setting to be hidden if guest mode is set, but did not ever remove the hidden flag. Thus, it was only ever hidden. In this CL the Reset Settings section is now visible by default. It still gets hidden by guest mode. BUG=407493 Committed: https://crrev.com/aa7e9b61d69dfa8e0a1557d900037bfb8b1e6e78 Cr-Commit-Position: refs/heads/master@{#291948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/options/browser_options.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Mike Lerman
mlerman@chromium.org changed reviewers: + estade@chromium.org
6 years, 3 months ago (2014-08-26 12:34:24 UTC) #1
Mike Lerman
Hi Evan, Need a follow-up patch to an earlier CL. Quick review please? Thanks!
6 years, 3 months ago (2014-08-26 12:34:24 UTC) #2
Evan Stade
lgtm
6 years, 3 months ago (2014-08-26 17:32:10 UTC) #3
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 3 months ago (2014-08-26 17:34:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/505143002/1
6 years, 3 months ago (2014-08-26 17:36:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as 657bedb61009378df9677d669bbe51802ab04e3e
6 years, 3 months ago (2014-08-26 18:45:27 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:44:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa7e9b61d69dfa8e0a1557d900037bfb8b1e6e78
Cr-Commit-Position: refs/heads/master@{#291948}

Powered by Google App Engine
This is Rietveld 408576698