Unit test of instruction selection for calls with deoptimization.

Unit test of instruction selection for calls with deoptimization.


BUG=
R=bmeurer@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=23467

[Jarin, 2014-08-26 10:52:48]

jarin@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Jarin, 2014-08-26 10:53:02]

Could you take a look?

[Jarin, 2014-08-26 14:35:50]

On 2014/08/26 10:53:02, jarin wrote:
> Could you take a look?

As discussed offline, the test now targets ARM, there is a check of the
corresponding frame state descriptor in the deopt table, and there is a new
option for filtering out the nop instructions.

I have also changed the structure of inputs to ArchDeoptimize to be similar to
CallCodeObject (deoptimization id as TempImmediate rather than encoding in the
misc field of the opcode).

[Jarin, 2014-08-27 07:42:20]

On 2014/08/26 14:35:50, jarin wrote:
> On 2014/08/26 10:53:02, jarin wrote:
> > Could you take a look?
> 
> As discussed offline, the test now targets ARM, there is a check of the
> corresponding frame state descriptor in the deopt table, and there is a new
> option for filtering out the nop instructions.
> 
> I have also changed the structure of inputs to ArchDeoptimize to be similar to
> CallCodeObject (deoptimization id as TempImmediate rather than encoding in the
> misc field of the opcode).

FYI, I have rebased with your changes and made the test platform independent.

[Benedikt Meurer, 2014-08-27 09:02:36]

LGTM with nits

https://codereview.chromium.org/505133002/diff/140001/test/compiler-unittests...
File test/compiler-unittests/instruction-selector-unittest.cc (right):

https://codereview.chromium.org/505133002/diff/140001/test/compiler-unittests...
test/compiler-unittests/instruction-selector-unittest.cc:405: Stream s =
m.Build(kAllWithoutNopInstructions);
Nit: Please rename to kAllExceptNopInstructions

https://codereview.chromium.org/505133002/diff/140001/test/compiler-unittests...
test/compiler-unittests/instruction-selector-unittest.cc:468: }
Nit: missing blank line for cpplint happiness.

[Jarin, 2014-08-27 15:56:32]

Committed patchset #9 manually as 23467 (presubmit successful).