Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 505103003: Fix memory leak. Make "V8 Linux - memcheck" build bot happy. (Closed)

Created:
6 years, 4 months ago by vogelheim
Modified:
6 years, 4 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix memory leak. Make "V8 Linux - memcheck" build bot happy. Flags::SetFlagsFromCommandLine allocates memory to hold copies of string arguments when calling Flag::set_string_value(..., true) and presently noone deallocates this. Resetting the flags will clear this memory. Since Flags can be used throughout the entire V8 lifetime, Dispose/Teardown seems like the right location to free this memory. This is rarely a problem in practice, but the memcheck buildbot (rightly) complains. BUG= R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23395

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/v8.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vogelheim
vogelheim@chromium.org changed reviewers: + machenbach@chromium.org
6 years, 4 months ago (2014-08-26 09:29:50 UTC) #1
vogelheim
@machenbach: Can I somehow trigger the 'memcheck' buildbot to verify this actually resolves the issue?
6 years, 4 months ago (2014-08-26 09:31:11 UTC) #2
Michael Achenbach
On 2014/08/26 09:31:11, vogelheim wrote: > @machenbach: Can I somehow trigger the 'memcheck' buildbot to ...
6 years, 4 months ago (2014-08-26 10:52:22 UTC) #3
vogelheim
6 years, 4 months ago (2014-08-26 11:01:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as 23395 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698