Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 505103002: X87: Eliminate code duplication in lithium calls to vector-based LoadICs (Closed)

Created:
6 years, 4 months ago by chunyang.dai
Modified:
6 years, 3 months ago
Reviewers:
Weiliang, mvstanton
CC:
v8-dev, danno
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

X87: Eliminate code duplication in lithium calls to vector-based LoadICs port r23359. original commit message: Eliminate code duplication in lithium calls to vector-based LoadICs BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -21 lines) Patch
M src/x87/lithium-codegen-x87.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 4 chunks +16 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
chunyang.dai
chunyang.dai@intel.com changed reviewers: + mvstanton@chromium.org, weiliang.lin@intel.com
6 years, 4 months ago (2014-08-26 05:09:39 UTC) #1
Weiliang
lgtm
6 years, 4 months ago (2014-08-26 05:35:15 UTC) #2
chunyang.dai
hello. weiliang. please review it. thanks.
6 years, 4 months ago (2014-08-26 06:12:12 UTC) #3
Weiliang
6 years, 4 months ago (2014-08-26 06:16:54 UTC) #4
Committed as r23382

Powered by Google App Engine
This is Rietveld 408576698