ServiceWorker: throw when close() or terminate() called

ServiceWorker: throw when close() or terminate() called

Per spec:
* ServiceWorker#terminate() should throw InvalidAccessError
* ServiceWorkerGlobalScope#close() should throw InvalidAccessError

... since the behaviors inherited from the base interfaces are not
supported.

Spec: slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html

BUG=398318
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181049

[jsbell, 2014-08-26 00:31:00]

I had a "bad karma" day so picked off something trivial from the bug list.

dominicc@ - please take a look? And CQ if the patch/try bots look green?

[jsbell, 2014-08-26 16:03:00]

jsbell@chromium.org changed reviewers:
+ horo@chromium.org, michaeln@chromium.org, nhiroki@chromium.org

[jsbell, 2014-08-26 16:03:00]

Ooops, dominicc@ is 'slow' - r? cq? anyone?

[jsbell, 2014-08-26 17:06:47]

jsbell@chromium.org changed reviewers:
- dominicc@chromium.org, michaeln@chromium.org, nhiroki@chromium.org

[jsbell, 2014-08-26 17:06:47]

I just noticed that the fetch tests (fetch.html, fetch-body-stream.html) racily
use self.close(). Those will need to be changed. I saw one fail locally.

horo@ - thoughts on updating those tests?

For now I'll just remove the self.close(); calls, and the outstanding fetch can
serve as a canary, even if it's not reliably shut down. We could also do a
"fetch loop" that tries to ensure there's always an outstanding fetch?

[horo, 2014-08-27 02:24:50]

https://codereview.chromium.org/505063002/diff/20001/LayoutTests/http/tests/s...
File LayoutTests/http/tests/serviceworker/resources/fetch-body-stream-worker.js
(left):

https://codereview.chromium.org/505063002/diff/20001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/fetch-body-stream-worker.js:11:
self.close();
It is ok to remove self.close() from fetch-body-stream-worker.js.

https://codereview.chromium.org/505063002/diff/20001/LayoutTests/http/tests/s...
File LayoutTests/http/tests/serviceworker/resources/fetch-worker.js (right):

https://codereview.chromium.org/505063002/diff/20001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/fetch-worker.js:22: // FIXME:
Since we can't ensure the context is torn down while
Could you please add this method

function runInfiniteFetchLoop() {
    fetch('dummy.html')
      .then(function() { runInfiniteFetchLoop(); })
}

and call this before port.postMessage('quit');?

[jsbell, 2014-08-27 16:27:09]

https://codereview.chromium.org/505063002/diff/20001/LayoutTests/http/tests/s...
File LayoutTests/http/tests/serviceworker/resources/fetch-worker.js (right):

https://codereview.chromium.org/505063002/diff/20001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/resources/fetch-worker.js:22: // FIXME:
Since we can't ensure the context is torn down while
On 2014/08/27 02:24:50, horo wrote:
> Could you please add this method
> 
> function runInfiniteFetchLoop() {
>     fetch('dummy.html')
>       .then(function() { runInfiniteFetchLoop(); })
> }
> 
> and call this before port.postMessage('quit');?

Done. Let's see what the try bots think.

[horo, 2014-08-28 01:01:01]

lgtm

[jsbell, 2014-08-28 16:45:12]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2014-08-28 16:45:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jsbell@chromium.org/505063002/40001

[commit-bot: I haz the power, 2014-08-28 16:50:25]

Committed patchset #3 (id:40001) as 181049

[mlamouri (slow - plz ping), 2014-08-28 17:23:33]

A revert of this CL (patchset #3) has been created in
https://codereview.chromium.org/515323002/ by mlamouri@chromium.org.

The reason for reverting is: Break compilation on various bots. Maybe Win only..