Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 505055: Merge trunk r35030 to the 249 branch (Closed)

Created:
11 years ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Merge trunk r35030 to the 249 branch. Adapt Chrome to use KeystoneRegistration 1.0.7.1306. Use "tag path" and "tag key" to direct Keystone to use a tag stored in the application as opposed to in its ticket. BUG=30730 TEST= - ksadmin --print-ticket --productid com.google.Chrome should show tagPath pointing to GC.app/Contents/Info.plist, and tagKey of KSChannelID; - ksadmin --print-tag --productid com.google.Chrome should show the value of the KSChannelID key in GC.app/Contents/Info.plist; this should be the tag that is used for autoupdates The above steps should be validated after the following operations: - launching Chrome when on a user ticket, - promoting Chrome from a user ticket to a system ticket, and - when a Chrome update is applied (using this version of keystone_install.sh) when on either a user or a system ticket. The tagPath and tagKey will NOT be set when launching Chrome on a system (promoted) ticket, but they WILL be set when the ticket is initially promoted and also when an update is applied using this version of keystone_install.sh. Review URL: http://codereview.chromium.org/506061 TBR=mark@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35031

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -43 lines) Patch
M chrome/browser/cocoa/keystone_glue.mm View 10 chunks +59 lines, -33 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/tools/build/mac/keystone_install.sh View 3 chunks +94 lines, -6 lines 0 comments Download
M chrome/tools/build/mac/keystone_install_test.sh View 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Mark Mentovai
11 years ago (2009-12-19 02:16:31 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698