Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 505033: Fix a crash in ChromeFrame caused by incorrectly instantiating the automation... (Closed)

Created:
11 years ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
stoyan
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Fix a crash in ChromeFrame caused by incorrectly instantiating the automation url request context used by the host network stack implementation with a NULL AutomationResourceMessageFilter pointer. Fixes bug http://code.google.com/p/chromium/issues/detail?id=29025 Will add a test for this in a subsequent CL. Bug=29025 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34855

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/external_tab_container.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
11 years ago (2009-12-17 06:34:36 UTC) #1
stoyan
11 years ago (2009-12-17 16:00:07 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698