Chromium Code Reviews
Help | Chromium Project | Sign in
(139)

Issue 505025: Implement issue 549 Make V8 call DebugMessageDispatchHandler with Locker locked (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by Peter Rybin
Modified:
2 years, 11 months ago
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Implement issue 549 Make V8 call DebugMessageDispatchHandler with Locker locked

Committed: http://code.google.com/p/v8/source/detail?r=3634

Patch Set 1 #

Patch Set 2 : clean-up #

Patch Set 3 : comments #

Patch Set 4 : merge and simplify sample script #

Patch Set 5 : merge #

Patch Set 6 : merge #

Patch Set 7 : rollback formatting #

Patch Set 8 : redo mutex #

Patch Set 9 : format #

Patch Set 10 : clean-up #

Patch Set 11 : rollback test #

Total comments: 2

Patch Set 12 : follow codereview #

Patch Set 13 : move debug command back #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -8 lines) Lint Patch
M include/v8-debug.h View 4 5 1 chunk +3 lines, -1 line 0 comments ? errors Download
M src/api.cc View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -3 lines 0 comments ? errors Download
M src/debug.h View 1 2 3 4 5 6 7 8 5 chunks +30 lines, -1 line 0 comments ? errors Download
M src/debug.cc View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +71 lines, -3 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 3
Peter Rybin
4 years, 3 months ago #1
Søren Thygesen Gjesse
LGTM http://codereview.chromium.org/505025/diff/14002/15009 File src/debug.cc (right): http://codereview.chromium.org/505025/diff/14002/15009#newcode2776 src/debug.cc:2776: sem_(OS::CreateSemaphore(0)), mutex_(OS::CreateMutex()), already_signalled_(false) { Long line.
4 years, 3 months ago #2
Peter Rybin
4 years, 3 months ago #3
I fixed formatting.

Also I realized that I should put back "StackGuard::DebugCommand();"
It was that with my new option I wait for Locker and only after this set
DebugCommand.
Now I put it back and it sets DebugCommand right when message arrives.

http://codereview.chromium.org/505025/diff/14002/15009
File src/debug.cc (right):

http://codereview.chromium.org/505025/diff/14002/15009#newcode2776
src/debug.cc:2776: sem_(OS::CreateSemaphore(0)), mutex_(OS::CreateMutex()),
already_signalled_(false) {
On 2010/01/18 10:32:21, Søren Gjesse wrote:
> Long line.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6