Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4334)

Unified Diff: chrome/browser/browser.cc

Issue 505013: All browser types should should open CURRENT_TAB in the current tab (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser.cc
===================================================================
--- chrome/browser/browser.cc (revision 34718)
+++ chrome/browser/browser.cc (working copy)
@@ -2973,7 +2973,9 @@
// If this is not a normal window (such as a popup or an application), we can
// only have one tab so a new tab always goes into a tabbed browser window.
- if (disposition != NEW_WINDOW && type_ != TYPE_NORMAL) {
+ if (type_ != TYPE_NORMAL &&
+ disposition != CURRENT_TAB &&
+ disposition != NEW_WINDOW) {
// If the disposition is OFF_THE_RECORD we don't want to create a new
// browser that will itself create another OTR browser. This will result in
// a browser leak (and crash below because no tab is created or selected).
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698