Assigning bugs to excluded test groups.

Assigning bugs to excluded test groups.

BUG=30360, 30366, 30367, 30370, 37371, 30373, 30375, 30378, 30379, 30381, 30382, 30384, 30386, 30390, 30391, 30392, 30393, 30394, 30396, 30397, 30398
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34803

[oshima, 2009-12-17 01:08:40]

no change to tests. just updating comments.

[viettrungluu, 2009-12-17 01:32:23]

Other than nitpicking about (some other) comments, LGTM.

[oshima, 2009-12-17 01:35:33]

I don't see your comments. I guess you just did "reply" instead of sending
comments?

On 2009/12/17 01:32:23, viettrungluu wrote:
> Other than nitpicking about (some other) comments, LGTM.

[viettrungluu, 2009-12-17 01:41:08]

You were entirely correct. Sorry about that.

http://codereview.chromium.org/505001/diff/2008/3002
File chrome/test/data/valgrind/ui_tests.gtest_mac.txt (right):

http://codereview.chromium.org/505001/diff/2008/3002#newcode27
chrome/test/data/valgrind/ui_tests.gtest_mac.txt:27: # Following tests are
failing on valgrind.
While you're there, could you correct this sentence?

"The following tests fail on valgrind:"

http://codereview.chromium.org/505001/diff/2008/3003
File chrome/test/data/valgrind/unit_tests.gtest_mac.txt (right):

http://codereview.chromium.org/505001/diff/2008/3003#newcode9
chrome/test/data/valgrind/unit_tests.gtest_mac.txt:9: # Following test fails on
valgrind.
"The following tests fail on valgrind:"

http://codereview.chromium.org/505001/diff/2008/3003#newcode27
chrome/test/data/valgrind/unit_tests.gtest_mac.txt:27: # Folowing tests does not
pass memcheck test.
"The following tests do not pass the memcheck test:"

[oshima, 2009-12-17 01:51:18]

all done.

On 2009/12/17 01:41:08, viettrungluu wrote:
> You were entirely correct. Sorry about that.
> 
> http://codereview.chromium.org/505001/diff/2008/3002
> File chrome/test/data/valgrind/ui_tests.gtest_mac.txt (right):
> 
> http://codereview.chromium.org/505001/diff/2008/3002#newcode27
> chrome/test/data/valgrind/ui_tests.gtest_mac.txt:27: # Following tests are
> failing on valgrind.
> While you're there, could you correct this sentence?
> 
> "The following tests fail on valgrind:"
> 
> http://codereview.chromium.org/505001/diff/2008/3003
> File chrome/test/data/valgrind/unit_tests.gtest_mac.txt (right):
> 
> http://codereview.chromium.org/505001/diff/2008/3003#newcode9
> chrome/test/data/valgrind/unit_tests.gtest_mac.txt:9: # Following test fails
on
> valgrind.
> "The following tests fail on valgrind:"
> 
> http://codereview.chromium.org/505001/diff/2008/3003#newcode27
> chrome/test/data/valgrind/unit_tests.gtest_mac.txt:27: # Folowing tests does
not
> pass memcheck test.
> "The following tests do not pass the memcheck test:"

[viettrungluu, 2009-12-17 02:06:50]

Great. LGTM.