Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 504963002: Subzero: Fixes for Hello World and bisection debugging. (Closed)

Created:
6 years, 3 months ago by Jim Stichnoth
Modified:
6 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Fixes for Hello World and bisection debugging. Add the llvm2ice -sandbox option (false by default) to select between native and sandboxed code generation. Currently, it controls whether the llvm.nacl.read.tp intrinsic is lowered to gs:[0x0] or a call to __nacl_read_tp. Change the asm output slightly for -ffunction-sections so that objdump is more willing to provide a disassembly. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=bfb03e5

Patch Set 1 #

Patch Set 2 : 80-char #

Total comments: 2

Patch Set 3 : Fix lit test prefix names. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -12 lines) Patch
M src/IceCfg.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceClFlags.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/IceTargetLoweringX8632.cpp View 1 2 chunks +14 lines, -7 lines 0 comments Download
M src/llvm2ice.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll View 1 2 5 chunks +25 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jim Stichnoth
6 years, 3 months ago (2014-08-25 20:44:30 UTC) #1
jvoung (off chromium)
LGTM https://codereview.chromium.org/504963002/diff/20001/tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll File tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll (right): https://codereview.chromium.org/504963002/diff/20001/tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll#newcode113 tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll:113: ; CHECKO2UREM-LABEL: test_memcpy I guess I should have ...
6 years, 3 months ago (2014-08-25 21:01:34 UTC) #2
Jim Stichnoth
https://codereview.chromium.org/504963002/diff/20001/tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll File tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll (right): https://codereview.chromium.org/504963002/diff/20001/tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll#newcode113 tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll:113: ; CHECKO2UREM-LABEL: test_memcpy On 2014/08/25 21:01:34, jvoung wrote: > ...
6 years, 3 months ago (2014-08-25 21:32:10 UTC) #3
Jim Stichnoth
6 years, 3 months ago (2014-08-26 17:29:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as bfb03e5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698