Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: net/quic/reliable_quic_stream_test.cc

Issue 504953003: Remove implicit conversions from scoped_refptr to T* in net/quic/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_stream_factory_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/reliable_quic_stream_test.cc
diff --git a/net/quic/reliable_quic_stream_test.cc b/net/quic/reliable_quic_stream_test.cc
index f188783e425c7a546ca262457db548d05cd3fde8..535e4408000f3a9deacb76cea1b5fc9ebce5271e 100644
--- a/net/quic/reliable_quic_stream_test.cc
+++ b/net/quic/reliable_quic_stream_test.cc
@@ -504,7 +504,7 @@ TEST_F(ReliableQuicStreamTest, WriteOrBufferDataWithQuicAckNotifier) {
// The arguments to delegate->OnAckNotification are the sum of the
// arguments to proxy_delegate OnAckNotification calls.
- EXPECT_CALL(*delegate, OnAckNotification(111, 222, 333, 444, zero_));
+ EXPECT_CALL(*delegate.get(), OnAckNotification(111, 222, 333, 444, zero_));
proxy_delegate->OnAckNotification(100, 200, 300, 400, zero_);
}
@@ -545,7 +545,7 @@ TEST_F(ReliableQuicStreamTest, WriteOrBufferDataAckNotificationBeforeFlush) {
stream_->OnCanWrite();
// Handle the ack for the second write.
- EXPECT_CALL(*delegate, OnAckNotification(101, 202, 303, 404, zero_));
+ EXPECT_CALL(*delegate.get(), OnAckNotification(101, 202, 303, 404, zero_));
proxy_delegate->OnAckNotification(100, 200, 300, 400, zero_);
}
@@ -566,7 +566,7 @@ TEST_F(ReliableQuicStreamTest, WriteAndBufferDataWithAckNotiferNoBuffer) {
EXPECT_FALSE(HasWriteBlockedStreams());
// Handle the ack.
- EXPECT_CALL(*delegate, OnAckNotification(1, 2, 3, 4, zero_));
+ EXPECT_CALL(*delegate.get(), OnAckNotification(1, 2, 3, 4, zero_));
proxy_delegate->OnAckNotification(1, 2, 3, 4, zero_);
}
@@ -591,7 +591,7 @@ TEST_F(ReliableQuicStreamTest, BufferOnWriteAndBufferDataWithAckNotifer) {
stream_->OnCanWrite();
// Handle the ack.
- EXPECT_CALL(*delegate, OnAckNotification(1, 2, 3, 4, zero_));
+ EXPECT_CALL(*delegate.get(), OnAckNotification(1, 2, 3, 4, zero_));
proxy_delegate->OnAckNotification(1, 2, 3, 4, zero_);
}
@@ -620,7 +620,7 @@ TEST_F(ReliableQuicStreamTest, WriteAndBufferDataWithAckNotiferOnlyFinRemains) {
// Handle the acks.
proxy_delegate->OnAckNotification(1, 2, 3, 4, zero_);
- EXPECT_CALL(*delegate, OnAckNotification(11, 22, 33, 44, zero_));
+ EXPECT_CALL(*delegate.get(), OnAckNotification(11, 22, 33, 44, zero_));
proxy_delegate->OnAckNotification(10, 20, 30, 40, zero_);
}
« no previous file with comments | « net/quic/quic_stream_factory_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698