net/quic/quic_client_session_test.cc - Issue 504953003: Remove implicit conversions from scoped_refptr to T* in net/quic/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_client_session_test.cc

Issue 504953003: Remove implicit conversions from scoped_refptr to T* in net/quic/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_client_session_test.cc

diff --git a/net/quic/quic_client_session_test.cc b/net/quic/quic_client_session_test.cc

index 39b2ae5a2c0537b585e480b9d42eeb5691989eae..2c000728668fb3aaed0e579d8a1fa0081c7e4e4a 100644

--- a/net/quic/quic_client_session_test.cc

+++ b/net/quic/quic_client_session_test.cc

@@ -153,7 +153,7 @@ TEST_P(QuicClientSessionTest, CanPool) {

ProofVerifyDetailsChromium details;

details.cert_verify_result.verified_cert =

ImportCertFromFile(GetTestCertsDirectory(), "spdy_pooling.pem");

- ASSERT_TRUE(details.cert_verify_result.verified_cert);

+ ASSERT_TRUE(details.cert_verify_result.verified_cert.get());

session_.OnProofVerifyDetailsAvailable(details);

CompleteCryptoHandshake();

@@ -174,7 +174,7 @@ TEST_P(QuicClientSessionTest, ConnectionPooledWithTlsChannelId) {

ProofVerifyDetailsChromium details;

details.cert_verify_result.verified_cert =

ImportCertFromFile(GetTestCertsDirectory(), "spdy_pooling.pem");

- ASSERT_TRUE(details.cert_verify_result.verified_cert);

+ ASSERT_TRUE(details.cert_verify_result.verified_cert.get());

session_.OnProofVerifyDetailsAvailable(details);

CompleteCryptoHandshake();

@@ -200,7 +200,7 @@ TEST_P(QuicClientSessionTest, ConnectionNotPooledWithDifferentPin) {

details.cert_verify_result.public_key_hashes.push_back(

GetTestHashValue(bad_pin));

- ASSERT_TRUE(details.cert_verify_result.verified_cert);

+ ASSERT_TRUE(details.cert_verify_result.verified_cert.get());

session_.OnProofVerifyDetailsAvailable(details);

CompleteCryptoHandshake();

@@ -222,7 +222,7 @@ TEST_P(QuicClientSessionTest, ConnectionPooledWithMatchingPin) {

details.cert_verify_result.public_key_hashes.push_back(

GetTestHashValue(primary_pin));

- ASSERT_TRUE(details.cert_verify_result.verified_cert);

+ ASSERT_TRUE(details.cert_verify_result.verified_cert.get());

session_.OnProofVerifyDetailsAvailable(details);

CompleteCryptoHandshake();

« no previous file with comments | « net/quic/quic_client_session.cc ('k') | net/quic/quic_connection_test.cc » ('j') | no next file with comments »