Chromium Code Reviews| Index: tools/metrics/histograms/find_unmapped_histograms.py |
| diff --git a/tools/metrics/histograms/find_unmapped_histograms.py b/tools/metrics/histograms/find_unmapped_histograms.py |
| index 443d1c6fa637413f68099e60d8f146bb65db4506..4d42eb8c75819a5fdf213b8e729067cd261e2dd9 100644 |
| --- a/tools/metrics/histograms/find_unmapped_histograms.py |
| +++ b/tools/metrics/histograms/find_unmapped_histograms.py |
| @@ -38,8 +38,8 @@ HISTOGRAM_REGEX = re.compile(r""" |
| \w* # Match the rest of the macro name, e.g. '_ENUMERATION' |
| \( # Match the opening parenthesis for the macro |
| \s* # Match any whitespace -- especially, any newlines |
| - ([^,]*) # Capture the first parameter to the macro |
| - , # Match the comma that delineates the first parameter |
| + ([^,)]*) # Capture the first parameter to the macro |
| + [,)] # Match the comma/bracket that delineates the first parameter |
|
Ilya Sherman
2014/08/30 01:17:13
nit: s/bracket/paren
Alexei Svitkine (slow)
2014/09/02 15:48:42
Done.
|
| """, re.VERBOSE) |
| @@ -113,10 +113,6 @@ def logNonLiteralHistogram(filename, histogram): |
| if '\\' in histogram: |
| return |
| - # Field trials are unique within a session, so are effectively constants. |
| - if histogram.startswith('base::FieldTrial::MakeName'): |
| - return |
| - |
| # Ignore histogram names that have been pulled out into C++ constants. |
| if CONSTANT_REGEX.match(histogram): |
| return |