A couple fixes to find_unmapped_histograms.py.

A couple fixes to find_unmapped_histograms.py.

- Treats ')' as a param delimeter for the macros.
  This makes SCOPED_UMA_HISTOGRAM_TIMER("Foo") not trigger
  the non-literal name warning.
- Removes check for FieldTrial::MakeName() which no longer exists.

BUG=none
NOTRY=true

Committed: https://crrev.com/b4b91fe81a17cb8235f49af94fd55a704c8c61b2
Cr-Commit-Position: refs/heads/master@{#292936}

[Ilya Sherman, 2014-08-26 00:27:24]

https://codereview.chromium.org/504943002/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/find_unmapped_histograms.py (right):

https://codereview.chromium.org/504943002/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/find_unmapped_histograms.py:41: ([^,\)]*)      #
Capture the first parameter to the macro
Hmm, do you really need to escape the paren within a [] range?  Seems
surprising.

https://codereview.chromium.org/504943002/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/find_unmapped_histograms.py:42: ,              # Match
the comma that delineates the first parameter
Does this not need to be updated to allow for a paren as well?

[Alexei Svitkine (slow), 2014-08-29 22:42:11]

https://codereview.chromium.org/504943002/diff/20001/tools/metrics/histograms...
File tools/metrics/histograms/find_unmapped_histograms.py (right):

https://codereview.chromium.org/504943002/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/find_unmapped_histograms.py:41: ([^,\)]*)      #
Capture the first parameter to the macro
On 2014/08/26 00:27:24, Ilya Sherman wrote:
> Hmm, do you really need to escape the paren within a [] range?  Seems
> surprising.

You're right, it wasn't necessary. Done.

https://codereview.chromium.org/504943002/diff/20001/tools/metrics/histograms...
tools/metrics/histograms/find_unmapped_histograms.py:42: ,              # Match
the comma that delineates the first parameter
On 2014/08/26 00:27:24, Ilya Sherman wrote:
> Does this not need to be updated to allow for a paren as well?

Done.

[Ilya Sherman, 2014-08-30 01:17:13]

LGTM, thanks :)

https://codereview.chromium.org/504943002/diff/40001/tools/metrics/histograms...
File tools/metrics/histograms/find_unmapped_histograms.py (right):

https://codereview.chromium.org/504943002/diff/40001/tools/metrics/histograms...
tools/metrics/histograms/find_unmapped_histograms.py:42: [,)]           # Match
the comma/bracket that delineates the first parameter
nit: s/bracket/paren

[Alexei Svitkine (slow), 2014-09-02 15:48:42]

https://codereview.chromium.org/504943002/diff/40001/tools/metrics/histograms...
File tools/metrics/histograms/find_unmapped_histograms.py (right):

https://codereview.chromium.org/504943002/diff/40001/tools/metrics/histograms...
tools/metrics/histograms/find_unmapped_histograms.py:42: [,)]           # Match
the comma/bracket that delineates the first parameter
On 2014/08/30 01:17:13, Ilya Sherman wrote:
> nit: s/bracket/paren

Done.

[Alexei Svitkine (slow), 2014-09-02 15:48:54]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2014-09-02 15:49:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/asvitkine@chromium.org/504943002/60001

[commit-bot: I haz the power, 2014-09-02 15:59:40]

Committed patchset #3 (id:60001) as ea4104f355bac79a905a88de4e7ad48da041dbb2

[commit-bot: I haz the power, 2014-09-10 03:18:48]

Patchset 3 (id:??) landed as
https://crrev.com/b4b91fe81a17cb8235f49af94fd55a704c8c61b2
Cr-Commit-Position: refs/heads/master@{#292936}