Allow JNI registration to be performed eagerly.

Allow JNI registration to be performed eagerly.

Add a content API function which allows JNI registration to
be performed immediately during JNI_OnLoad, instead of always
being deferred until LibraryLoaded.

Add a call to this new API in android_webview's entry point,
since it benefits from the eager registration by allowing
more pages to be shared, and for certain JNI functions to
be called without starting all of Chromium (e.g. to enable
AwCookieManager).

BUG=304813
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232696

[Yaron, 2013-10-31 21:28:30]

High-level: we already have so many forms of async startup with
BrowserController.java and browser_main_loop's StartupTaskRunner, that I'd like
to avoid another level of lazy. I had a suggestion for making it explicitly
different for webview but it's functionally the same.

https://codereview.chromium.org/50493015/diff/1/content/app/android/library_l...
File content/app/android/library_loader_hooks.cc (right):

https://codereview.chromium.org/50493015/diff/1/content/app/android/library_l...
content/app/android/library_loader_hooks.cc:144: bool
RegisterLibraryLoaderEntryHook(JNIEnv* env, bool lazy_jni_registration) {
Alternatively, just make DoJniRegistration public (maybe call it,
EnsureJniRegistered). Then webview can just force the initialization early and
other callers aren't affected

[Torne, 2013-11-01 11:35:16]

On 2013/10/31 21:28:30, Yaron wrote:
> High-level: we already have so many forms of async startup with
> BrowserController.java and browser_main_loop's StartupTaskRunner, that I'd
like
> to avoid another level of lazy. I had a suggestion for making it explicitly
> different for webview but it's functionally the same.
> 
>
https://codereview.chromium.org/50493015/diff/1/content/app/android/library_l...
> File content/app/android/library_loader_hooks.cc (right):
> 
>
https://codereview.chromium.org/50493015/diff/1/content/app/android/library_l...
> content/app/android/library_loader_hooks.cc:144: bool
> RegisterLibraryLoaderEntryHook(JNIEnv* env, bool lazy_jni_registration) {
> Alternatively, just make DoJniRegistration public (maybe call it,
> EnsureJniRegistered). Then webview can just force the initialization early and
> other callers aren't affected

That's a much better idea; uploaded a new CL that does it that way instead.

I've also updated the description to link to the correct bug and expand slightly
on what this is for, as you noted in the other CL I sent you that's part of the
same bug.

[Torne, 2013-11-01 11:40:26]

+joi for content/public OWNERS

[Jói, 2013-11-01 12:04:53]

//content/public LGTM.

[Yaron, 2013-11-01 16:35:07]

lgtm

Please update the Cl description (it's still based on old approach)

[Torne, 2013-11-01 16:37:38]

On 2013/11/01 16:35:07, Yaron wrote:
> lgtm
> 
> Please update the Cl description (it's still based on old approach)

Oops, forgot. Thanks for pointing it out; updated.

[commit-bot: I haz the power, 2013-11-01 16:47:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/torne@chromium.org/50493015/80001

[commit-bot: I haz the power, 2013-11-01 19:10:09]

Retried try job too often on linux_chromeos for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-11-04 10:42:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/torne@chromium.org/50493015/80001

[commit-bot: I haz the power, 2013-11-04 12:25:44]

Change committed as 232696