Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: sql/recovery.h

Issue 50493012: [sql] Recover Favicons v5 databases, with more recovery automation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase and cleanup Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sql/recovery.h
diff --git a/sql/recovery.h b/sql/recovery.h
index be23e97a76b20c70e0820c92d16a3337cca84d19..9bdb3ab2c5400bfd4201805b989f743e5b6fbd51 100644
--- a/sql/recovery.h
+++ b/sql/recovery.h
@@ -93,6 +93,44 @@ class SQL_EXPORT Recovery {
// Handle to the temporary recovery database.
sql::Connection* db() { return &recover_db_; }
+ // Attempt to recover the named table from the corrupt database into
+ // the recovery database using a temporary recover virtual table.
+ // The virtual table schema is derived from the named table's schema
+ // in database [main]. Data is copied using INSERT OR REPLACE, so
+ // duplicates overwrite each other.
+ //
+ // |extend_columns| allows recovering tables which have excess
+ // columns relative to the target schema. The recover virtual table
+ // treats more data than specified as a sign of corruption.
+ //
+ // Returns true if all operations succeeded.
+ //
+ // NOTE(shess): Due to a flaw in the recovery virtual table, at this
+ // time this code injects the DEFAULT value of the target table in
+ // locations where the recovery table returns NULL. This is not
+ // entirely correct, because it happens both when there is a short
+ // row (correct) but also where there is an actual NULL value
+ // (incorrect).
+ //
+ // TODO(shess): Flag for INSERT OR REPLACE vs IGNORE.
+ // TODO(shess): Expose number of rows copied.
+ // TODO(shess): Handle extended table names.
+ bool AutoRecoverTable(const char* table_name, size_t extend_columns);
+
+ // Setup a recover virtual table at temp.recover_meta, reading from
+ // corrupt.meta. Returns true if created.
+ // TODO(shess): Perhaps integrate into Begin().
+ // TODO(shess): Add helpers to fetch additional items from the meta
+ // table as needed.
+ bool SetupMeta();
+
+ // Fetch the version number from temp.recover_meta. Returns false
+ // if the query fails, or if there is no version row. Otherwise
+ // returns true, with the version in |*version_number|.
+ //
+ // Only valid to call after successful SetupMeta().
+ bool GetMetaVersionNumber(int* version_number);
+
private:
explicit Recovery(Connection* connection);

Powered by Google App Engine
This is Rietveld 408576698