Issue 504883003: Revert of Use number of components from ICC profile and alternateCS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 504883003: Revert of Use number of components from ICC profile and alternateCS (Closed)

Created:
6 years, 4 months ago by Bo Xu

Modified:
5 years, 9 months ago

Reviewers:
Tom Sepez, jun_fang

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Visibility:
Public.

Revert of Use number of components from ICC profile and alternateCS (patchset #1 of https://codereview.chromium.org/493163003/) Reason for revert: Needs to address comments before landing Original issue's description: > Use number of components from ICC profile and alternate color space > > BUG=406806 > > Committed: https://pdfium.googlesource.com/pdfium/+/be83103 TBR=tsepez@chromium.org,jun_fang@foxitsoftware.com NOTREECHECKS=true NOTRY=true BUG=406806 Committed: https://pdfium.googlesource.com/pdfium/+/a550e4c

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -110 lines)			Patch
M	core/include/fpdfapi/fpdf_parser.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	core/include/fxcodec/fx_codec.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp	View	1	2 chunks	+31 lines, -55 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_page/pageint.h	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download
M	core/src/fxcodec/codec/codec_int.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	core/src/fxcodec/codec/fx_codec_icc.cpp	View	1	9 chunks	+17 lines, -40 lines	0 comments	Download

Total messages: 4 (0 generated)

Bo Xu

Created Revert of Use number of components from ICC profile and alternateCS

6 years, 4 months ago (2014-08-25 18:37:02 UTC) #1

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 4 months ago (2014-08-25 18:40:53 UTC) #2

commit-bot: I haz the power

Commit queue rejected this change because it did not recognize the base URL. Please commit ...

6 years, 4 months ago (2014-08-25 18:40:54 UTC) #3

Bo Xu

6 years, 4 months ago (2014-08-25 18:52:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as a550e4c (presubmit successful).