Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1742)

Unified Diff: ash/wm/workspace/workspace_layout_manager_unittest.cc

Issue 504793003: Resize BrowserFrameAsh and not RenderWidgetHostViewAura when keyboard bounds change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add unittest. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/workspace/workspace_layout_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/workspace/workspace_layout_manager_unittest.cc
diff --git a/ash/wm/workspace/workspace_layout_manager_unittest.cc b/ash/wm/workspace/workspace_layout_manager_unittest.cc
index a5fa688c4cd009eb53c4fb7b106738ae61a952d5..307bc7dd3eb2704f6cb64064919ed03105e62417 100644
--- a/ash/wm/workspace/workspace_layout_manager_unittest.cc
+++ b/ash/wm/workspace/workspace_layout_manager_unittest.cc
@@ -1080,6 +1080,18 @@ TEST_F(WorkspaceLayoutManagerKeyboardTest, AdjustWindowForA11yKeyboard) {
HideKeyboard();
EXPECT_EQ(small_window_bound.ToString(), window->bounds().ToString());
+ const gfx::Rect occluded_window_bound(50, keyboard_bounds.y(),
+ 100, keyboard_bounds.height()/2);
+ window->SetBounds(occluded_window_bound);
+ EXPECT_EQ(occluded_window_bound.ToString(), window->bounds().ToString());
+ ShowKeyboard();
+ EXPECT_EQ(gfx::Rect(occluded_window_bound.x(),
+ occluded_window_bound.y() - keyboard_bounds.y()/2,
+ occluded_window_bound.width(),
+ occluded_window_bound.height()).ToString(), window->bounds().ToString());
+ HideKeyboard();
+ EXPECT_EQ(occluded_window_bound.ToString(), window->bounds().ToString());
flackr 2014/08/25 15:25:30 This test looks like it would pass on master as th
+
if (switches::IsTextInputFocusManagerEnabled()) {
ui::TextInputFocusManager::GetInstance()->BlurTextInputClient(
&text_input_client);
« no previous file with comments | « ash/wm/workspace/workspace_layout_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698