Teach chromium_roll script to roll v8 git hashes.

tools/push-to-trunk/chromium_roll.py

 #!/usr/bin/env python
 # Copyright 2014 the V8 project authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import argparse
 import os
 import sys
 
 from common_includes import *
@@ skipping 66 matching lines @@
 
 
 class UploadCL(Step):
   MESSAGE = "Create and upload CL."
   REQUIRES = "chrome_path"
 
   def RunStep(self):
     os.chdir(self["chrome_path"])
 
     # Patch DEPS file.
-    deps = FileToText(self.Config(DEPS_FILE))
-    deps = re.sub("(?<=\"v8_revision\": \")([0-9]+)(?=\")",
-                  self["trunk_revision"],
-                  deps)
-    TextToFile(deps, self.Config(DEPS_FILE))
+    if self._side_effect_handler.Command(
+        "roll-dep", "v8 %s" % self["trunk_revision"]) is None:

[Ryan Tseng, 2014/08/25 13:51:55]

nit: if foo() is None: -> if not foo(): to match chromium style

edit: okay scratch that, I see the Command() implementation >_<

+      self.Die("Failed to create deps for %s" % self["trunk_revision"])
 
     if self._options.reviewer and not self._options.manual:
       print "Using account %s for review." % self._options.reviewer
       rev = self._options.reviewer
     else:
       print "Please enter the email address of a reviewer for the roll CL: ",
       self.DieNoManualMode("A reviewer must be specified in forced mode.")
       rev = self.ReadLine()
 
     commit_title = "Update V8 to %s." % self["push_title"].lower()
@@ skipping 69 matching lines @@
       SwitchChromium,
       UpdateChromiumCheckout,
       UploadCL,
       SwitchV8,
       CleanUp,
     ]
 
 
 if __name__ == "__main__":  # pragma: no cover
   sys.exit(ChromiumRoll(CONFIG).Run())