Add Cookie permission to Website Settings single side view.

Add Cookie permission to Website Settings single side view.

BUG=372607
Committed: https://crrev.com/65ba59b3762a1a74890b004d3ea2c6921f5df99c
Cr-Commit-Position: refs/heads/master@{#291966}

[Daniel Nishi, 2014-08-25 17:51:07]

dhnishi@chromium.org changed reviewers:
+ bauerb@chromium.org

[Daniel Nishi, 2014-08-25 17:51:08]

bauerb: PTAL when you get a moment.

[Bernhard Bauer, 2014-08-26 08:12:27]

https://codereview.chromium.org/504773004/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/website_settings_edit_site.html (right):

https://codereview.chromium.org/504773004/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/website_settings_edit_site.html:40: <select
id="cookies-select-option"
Indent two more spaces.

https://codereview.chromium.org/504773004/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/website_settings_handler.cc (right):

https://codereview.chromium.org/504773004/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/website_settings_handler.cc:33:
CONTENT_SETTINGS_TYPE_GEOLOCATION, CONTENT_SETTINGS_TYPE_NOTIFICATIONS,
Put each on an individual line.

https://codereview.chromium.org/504773004/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/website_settings_handler.cc:397: if
(permission_type == CONTENT_SETTINGS_TYPE_COOKIES)
Wrap multiline bodies in braces.

[Daniel Nishi, 2014-08-26 17:26:01]

Patchset #2 (id:20001) has been deleted

[Daniel Nishi, 2014-08-26 17:26:50]

https://codereview.chromium.org/504773004/diff/1/chrome/browser/resources/opt...
File chrome/browser/resources/options/website_settings_edit_site.html (right):

https://codereview.chromium.org/504773004/diff/1/chrome/browser/resources/opt...
chrome/browser/resources/options/website_settings_edit_site.html:40: <select
id="cookies-select-option"
On 2014/08/26 08:12:27, Bernhard Bauer wrote:
> Indent two more spaces.

Done.

https://codereview.chromium.org/504773004/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/website_settings_handler.cc (right):

https://codereview.chromium.org/504773004/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/website_settings_handler.cc:33:
CONTENT_SETTINGS_TYPE_GEOLOCATION, CONTENT_SETTINGS_TYPE_NOTIFICATIONS,
On 2014/08/26 08:12:27, Bernhard Bauer wrote:
> Put each on an individual line.

Done.

https://codereview.chromium.org/504773004/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/website_settings_handler.cc:397: if
(permission_type == CONTENT_SETTINGS_TYPE_COOKIES)
On 2014/08/26 08:12:27, Bernhard Bauer wrote:
> Wrap multiline bodies in braces.

Done.

[Bernhard Bauer, 2014-08-26 17:29:22]

lgtm

[Daniel Nishi, 2014-08-26 17:46:01]

The CQ bit was checked by dhnishi@chromium.org

[commit-bot: I haz the power, 2014-08-26 17:46:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dhnishi@chromium.org/504773004/40001

[commit-bot: I haz the power, 2014-08-26 18:44:40]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)
  mac_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_triggered...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[commit-bot: I haz the power, 2014-08-26 19:39:43]

Committed patchset #2 (40001) as 31ace26c02ad6b0d90de8735837522c5f5f01262

[commit-bot: I haz the power, 2014-09-10 02:45:01]

Patchset 2 (id:??) landed as
https://crrev.com/65ba59b3762a1a74890b004d3ea2c6921f5df99c
Cr-Commit-Position: refs/heads/master@{#291966}