Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 504763002: Revert of Added PrintingContext::Delegate to get parent view handle and application locale. (Closed)

Created:
6 years, 3 months ago by Finnur
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Revert of Added PrintingContext::Delegate to get parent view handle and application locale. (patchset #13 of https://codereview.chromium.org/478183005/) Reason for revert: PrintJobTest.SimplePrint leaking on Linux ASAN bots since this was checked in: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29?numbuilds=100 This CL looks like the likeliest culprit. Original issue's description: > Added PrintingContext::Delegate to get parent view handle and application locale. > > BUG=374321 > > Committed: https://chromium.googlesource.com/chromium/src/+/ee8f4e4029c09ba77e7dbb8fddd85186642b3de8 TBR=noamsml@chromium.org,inferno@chromium.org,yzshen@chromium.org,thestig@chromium.org,jschuh@chromium.org,vitalybuka@chromium.org NOTREECHECKS=true NOTRY=true BUG=374321 Committed: https://crrev.com/c921afdcc249a89bd9e8cc1cc898e4c320cc5d03 Cr-Commit-Position: refs/heads/master@{#291654}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -248 lines) Patch
M chrome/browser/printing/print_job_manager.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/printing/print_job_manager.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/printing/print_job_unittest.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/printing/print_job_worker.h View 6 chunks +7 lines, -11 lines 0 comments Download
M chrome/browser/printing/print_job_worker.cc View 11 chunks +20 lines, -77 lines 0 comments Download
M chrome/browser/printing/printer_query.h View 3 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/printing/printer_query.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/printing/printing_message_filter.h View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/printing/printing_message_filter.cc View 4 chunks +74 lines, -30 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 chunk +2 lines, -11 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_print_settings_manager.cc View 2 chunks +1 line, -14 lines 0 comments Download
M printing/emf_win_unittest.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M printing/printing_context.h View 6 chunks +9 lines, -20 lines 0 comments Download
M printing/printing_context.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M printing/printing_context_android.h View 2 chunks +2 lines, -1 line 0 comments Download
M printing/printing_context_android.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M printing/printing_context_linux.h View 2 chunks +2 lines, -1 line 0 comments Download
M printing/printing_context_linux.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M printing/printing_context_mac.h View 1 chunk +2 lines, -1 line 0 comments Download
M printing/printing_context_mac.mm View 3 chunks +7 lines, -7 lines 0 comments Download
M printing/printing_context_no_system_dialog.h View 1 chunk +2 lines, -1 line 0 comments Download
M printing/printing_context_no_system_dialog.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M printing/printing_context_win.h View 1 chunk +3 lines, -2 lines 0 comments Download
M printing/printing_context_win.cc View 1 chunk +8 lines, -10 lines 0 comments Download
M printing/printing_context_win_unittest.cc View 4 chunks +6 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Finnur
Created Revert of Added PrintingContext::Delegate to get parent view handle and application locale.
6 years, 3 months ago (2014-08-25 10:07:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/finnur@chromium.org/504763002/1
6 years, 3 months ago (2014-08-25 10:07:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (1) as ec39c9df15d1af73543d8ac3fe484c4de7ad3e9f
6 years, 3 months ago (2014-08-25 10:08:25 UTC) #3
Vitaly Buka (NO REVIEWS)
thanks, LGTM
6 years, 3 months ago (2014-08-25 23:47:11 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:33:31 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c921afdcc249a89bd9e8cc1cc898e4c320cc5d03
Cr-Commit-Position: refs/heads/master@{#291654}

Powered by Google App Engine
This is Rietveld 408576698