Test WebRTC - Peerconnection_manual.js: throw new Error line prevented rest of function from being …

chrome/test/data/webrtc/manual/peerconnection_manual.js

Index: chrome/test/data/webrtc/manual/peerconnection_manual.js
diff --git a/chrome/test/data/webrtc/manual/peerconnection_manual.js b/chrome/test/data/webrtc/manual/peerconnection_manual.js
index a8ce31df9933a78e33cd6e301bc6585578d7e9e9..664a954c0ea59555fe43d4bcc75d78b48c054cee 100644
--- a/chrome/test/data/webrtc/manual/peerconnection_manual.js
+++ b/chrome/test/data/webrtc/manual/peerconnection_manual.js
@@ -1156,16 +1156,18 @@ function error_(message) {
  * @param {string} color Color of the text.
  */
 function print_handler_(message, textField, color) {
-  if (color == 'red' )
-    throw new Error(message);
-
-  if (color == 'green' )
-    message += ' success';
+  try {

[perkj_chrome, 2014/08/25 11:59:13]

This looks weird. Isn't the point of this throw that you want to through the
exception.

Otherwise- why not just do want you wanted to have done before throwing the
exception.

+    if (color == 'red' )
+      throw new Error(message);
+  } finally {
+    if (color == 'green' )
+      message += ' success';
 
-  $(textField).innerHTML += '<span style="color:' + color + ';">' + message +
-                            '</span><br>'
+    $(textField).innerHTML += '<span style="color:' + color + ';">' + message +
+                              '</span><br>'
 
-  console.log(message);
+    console.log(message);
+  }
 }
 
 /**