Test WebRTC - Peerconnection_manual.js: throw new Error line prevented rest of function from being …

chrome/test/data/webrtc/manual/peerconnection_manual.js

 /**
  * Copyright 2014 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
  /**
  * See http://dev.w3.org/2011/webrtc/editor/getusermedia.html for more
  * information on getUserMedia. See
  * http://dev.w3.org/2011/webrtc/editor/webrtc.html for more information on
@@ skipping 1138 matching lines @@
   print_handler_(message, 'debug', 'red');
 }
 
 /**
  * @private
  * @param {string} message Text to print.
  * @param {string} textField Element ID of where to print.
  * @param {string} color Color of the text.
  */
 function print_handler_(message, textField, color) {
-  if (color == 'red' )
-    throw new Error(message);
+  try {

[perkj_chrome, 2014/08/25 11:59:13]

This looks weird. Isn't the point of this throw that you want to through the
exception.

Otherwise- why not just do want you wanted to have done before throwing the
exception.

+    if (color == 'red' )
+      throw new Error(message);
+  } finally {
+    if (color == 'green' )
+      message += ' success';
 
-  if (color == 'green' )
-    message += ' success';
+    $(textField).innerHTML += '<span style="color:' + color + ';">' + message +
+                              '</span><br>'
 
-  $(textField).innerHTML += '<span style="color:' + color + ';">' + message +
-                            '</span><br>'
-
-  console.log(message);
+    console.log(message);
+  }
 }
 
 /**
  * @private
  * @param {string} stringRepresentation JavaScript as a string.
  * @return {Object} The PeerConnection constraints as a JavaScript dictionary.
  */
 function getEvaluatedJavaScript_(stringRepresentation) {
   try {
     var evaluatedJavaScript;
@@ skipping 232 matching lines @@
 
 /** @private */
 function readResponseHeader_(request, key) {
   var value = request.getResponseHeader(key);
   if (value == null || value.length == 0) {
     error_('Received empty value ' + value +
            ' for response header key ' + key + '.');
   }
   return parseInt(value);
 }