Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 504753002: Test WebRTC - Peerconnection_manual.js: throw new Error line prevented rest of function from being … (Closed)

Created:
6 years, 3 months ago by mcasas
Modified:
6 years, 3 months ago
Reviewers:
perkj_chrome, jansson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Test WebRTC - Peerconnection_manual.js: throw new Error line prevented rest of function from being executed. BUG=None Committed: https://crrev.com/1533986744d9dd0be2da71aba776957bf6766429 Cr-Commit-Position: refs/heads/master@{#291683}

Patch Set 1 #

Total comments: 1

Patch Set 2 : perkj@ comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/test/data/webrtc/manual/peerconnection_manual.js View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mcasas
jansson@ PTAL perkj@: RS (need at least one committer approval).
6 years, 3 months ago (2014-08-25 10:08:20 UTC) #1
perkj_chrome
https://codereview.chromium.org/504753002/diff/1/chrome/test/data/webrtc/manual/peerconnection_manual.js File chrome/test/data/webrtc/manual/peerconnection_manual.js (right): https://codereview.chromium.org/504753002/diff/1/chrome/test/data/webrtc/manual/peerconnection_manual.js#newcode1159 chrome/test/data/webrtc/manual/peerconnection_manual.js:1159: try { This looks weird. Isn't the point of ...
6 years, 3 months ago (2014-08-25 11:59:13 UTC) #2
mcasas
PTAL
6 years, 3 months ago (2014-08-25 12:02:27 UTC) #3
jansson
On 2014/08/25 12:02:27, mcasas wrote: > PTAL LGTM, bad testing on my part in the ...
6 years, 3 months ago (2014-08-25 12:29:51 UTC) #4
perkj_chrome
lgtm
6 years, 3 months ago (2014-08-25 12:48:19 UTC) #5
mcasas
The CQ bit was checked by mcasas@chromium.org
6 years, 3 months ago (2014-08-25 12:51:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/504753002/20001
6 years, 3 months ago (2014-08-25 12:52:13 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-25 14:14:42 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (20001) as f084e84b8d0bfed74f79d158114d7859c6d6a174
6 years, 3 months ago (2014-08-25 15:25:33 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:34:33 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1533986744d9dd0be2da71aba776957bf6766429
Cr-Commit-Position: refs/heads/master@{#291683}

Powered by Google App Engine
This is Rietveld 408576698