Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 504723003: Silence a warning in unit tests (Closed)

Created:
6 years, 4 months ago by binjin
Modified:
6 years, 3 months ago
Reviewers:
Joao da Silva
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Silence a warning in generate_policy_source_unittest.cc. For non-CrOS, compiler gives warning regarding unused functions. BUG=NONE Committed: https://crrev.com/3d6b1ddbbc2b0f4f541b433f6c33bb64d4246812 Cr-Commit-Position: refs/heads/master@{#291680}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/policy/core/common/generate_policy_source_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
binjin
Hello Joao, Could you have a quick look at this? bjin
6 years, 4 months ago (2014-08-25 12:44:33 UTC) #1
Joao da Silva
lgtm
6 years, 4 months ago (2014-08-25 12:53:16 UTC) #2
binjin
The CQ bit was checked by binjin@chromium.org
6 years, 4 months ago (2014-08-25 13:06:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binjin@chromium.org/504723003/1
6 years, 4 months ago (2014-08-25 13:07:13 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-25 14:01:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as 562eba68fd09909257e05a08fb9a9d2258f6d7bc
6 years, 4 months ago (2014-08-25 14:39:11 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:34:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d6b1ddbbc2b0f4f541b433f6c33bb64d4246812
Cr-Commit-Position: refs/heads/master@{#291680}

Powered by Google App Engine
This is Rietveld 408576698