Issue 504713002: Enable upload sync errors for passwords.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 504713002: Enable upload sync errors for passwords. (Closed)

Created:
6 years, 4 months ago by vasilii

Modified:
6 years, 3 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Enable upload sync errors for passwords. https://codereview.chromium.org/470653003/ disabled uploading errors for all the data types. However, that change should have touched only favicons. BUG=384552, 396900 Committed: https://crrev.com/6714b22527a5487737bed216e31f928f860e7b85 Cr-Commit-Position: refs/heads/master@{#291756}

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	chrome/browser/sync/glue/chrome_report_unrecoverable_error.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/sync/profile_sync_components_factory_impl.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 6 (0 generated)

vasilii

Hi Nicolas, I'm fixing crbug/396900. For me it's important to be able to serf the ...

6 years, 4 months ago (2014-08-25 09:34:55 UTC) #1

Nicolas Zea

Ah, sorry, forgot you were still investigating this issue. LGTM

6 years, 4 months ago (2014-08-25 17:34:59 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/504713002/1

6 years, 3 months ago (2014-08-25 19:53:24 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (1) as 9cfc75d83198b387ba48da012b08ec9a7f392619

6 years, 3 months ago (2014-08-25 20:46:02 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:37:23 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6714b22527a5487737bed216e31f928f860e7b85
Cr-Commit-Position: refs/heads/master@{#291756}