Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 50463003: Merged r17425, r17428 into trunk branch. (Closed)

Created:
7 years, 1 month ago by Jakob Kummerow
Modified:
7 years, 1 month ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Merged r17425, r17428 into trunk branch. Temporarily allow HistogramTimerScopes to be nested ia32: Fix comparisons of two constant double operands when exactly one of them is in new space. R=yangguo@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17429

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -15 lines) Patch
M src/counters.h View 1 chunk +31 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M src/parser.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-compare-constant-doubles.js View 1 chunk +24 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
7 years, 1 month ago (2013-10-29 14:55:50 UTC) #1
Yang
On 2013/10/29 14:55:50, Jakob wrote: lgtm.
7 years, 1 month ago (2013-10-29 14:57:46 UTC) #2
Jakob Kummerow
7 years, 1 month ago (2013-10-29 14:58:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17429 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698