Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 504593002: Move a set of extensions tests into extensions_unittests target. (Closed)

Created:
6 years, 4 months ago by tfarina
Modified:
6 years, 3 months ago
Reviewers:
James Cook, Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Derek Bruening, Timur Iskhodzhanov
Project:
chromium
Visibility:
Public.

Description

Move a set of extensions tests into extensions_unittests target. This is the set of tests that do not require any change to run as part of extensions_unittests suite. BUG=397165 TEST=extensions_unittests R=jamescook@chromium.org TBR=yoz@chromium.org Committed: https://crrev.com/249e8303c1fb673d632c7e0a0cc40ed4fa3018fe Cr-Commit-Position: refs/heads/master@{#291620}

Patch Set 1 #

Patch Set 2 : REBASE #

Total comments: 2

Patch Set 3 : sync GN file with GYP #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
M extensions/BUILD.gn View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tfarina
Lets start with the easy ones. KISS. I will work on the others later. Regards,
6 years, 4 months ago (2014-08-23 03:28:44 UTC) #1
James Cook
LGTM What's going on with extensions_unittests on the memory waterfalls? I'd like to make sure ...
6 years, 4 months ago (2014-08-23 05:12:12 UTC) #2
James Cook
Also, what about the debug trybots? I added a couple more try jobs to see ...
6 years, 4 months ago (2014-08-23 05:40:45 UTC) #3
tfarina
James, answering your memory questions: - We have it running on Dr. Memory and memory ...
6 years, 4 months ago (2014-08-23 22:17:54 UTC) #4
tfarina
TBRing Yoyo for this (trivial, reviewed by James)... https://codereview.chromium.org/504593002/diff/20001/extensions/extensions.gyp File extensions/extensions.gyp (right): https://codereview.chromium.org/504593002/diff/20001/extensions/extensions.gyp#newcode912 extensions/extensions.gyp:912: 'common/extension_resource_unittest.cc', ...
6 years, 4 months ago (2014-08-24 03:53:02 UTC) #5
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-08-24 03:53:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/504593002/40001
6 years, 4 months ago (2014-08-24 03:54:45 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (40001) as fabea1c7f6cdcb387fd4d8bfe8e3318bdc4c0e7f
6 years, 4 months ago (2014-08-24 05:13:27 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:32:22 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/249e8303c1fb673d632c7e0a0cc40ed4fa3018fe
Cr-Commit-Position: refs/heads/master@{#291620}

Powered by Google App Engine
This is Rietveld 408576698