[Android] Expose method for UI to force composites

[Android] Expose method for UI to force composites

Allow the ContentViewRenderView to request composites if UX components require it.

BUG=387177
Committed: https://crrev.com/e3ed0e0a71cff087bb2a9a082c16ca3617966d7c
Cr-Commit-Position: refs/heads/master@{#291982}

[David Trainor- moved to gerrit, 2014-08-23 00:09:38]

ptal thanks!

[Ted C, 2014-08-23 00:47:11]

lgtm

https://codereview.chromium.org/504553002/diff/1/content/browser/android/cont...
File content/browser/android/content_view_render_view.cc (right):

https://codereview.chromium.org/504553002/diff/1/content/browser/android/cont...
content/browser/android/content_view_render_view.cc:123: SetNeedsComposite(env,
obj);
was this missing from before?

https://codereview.chromium.org/504553002/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java
(right):

https://codereview.chromium.org/504553002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java:151:
* This method should only be called if something in the UI requires a redraw of
the compositor.
Hmm...I would phrase this more as:

"Trigger a redraw of the compositor.  <Warning that it is only needed if the UI
changes something that will not trigger the redraw itself>."

[no sievers, 2014-08-25 17:20:42]

lgtm

https://codereview.chromium.org/504553002/diff/1/content/browser/android/cont...
File content/browser/android/content_view_render_view.cc (right):

https://codereview.chromium.org/504553002/diff/1/content/browser/android/cont...
content/browser/android/content_view_render_view.cc:123: SetNeedsComposite(env,
obj);
On 2014/08/23 00:47:11, Ted C wrote:
> was this missing from before?

am also wondering why this is needed

[David Trainor- moved to gerrit, 2014-08-25 17:30:05]

https://codereview.chromium.org/504553002/diff/1/content/browser/android/cont...
File content/browser/android/content_view_render_view.cc (right):

https://codereview.chromium.org/504553002/diff/1/content/browser/android/cont...
content/browser/android/content_view_render_view.cc:123: SetNeedsComposite(env,
obj);
On 2014/08/25 17:20:42, sievers wrote:
> On 2014/08/23 00:47:11, Ted C wrote:
> > was this missing from before?
> 
> am also wondering why this is needed

I saw we had this in CompositorView and assumed us not having it here was a bug.
 SetHasTransparentBackground doesn't seem to trigger any invalidate on the
LayerTreeHost, so I assumed that was why we had it in CompositorView downstream.

If you would like I can remove it until we see if it is an issue.  I imagine
frames from the renderer probably hide any bugs missing this might cause.

https://codereview.chromium.org/504553002/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java
(right):

https://codereview.chromium.org/504553002/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java:151:
* This method should only be called if something in the UI requires a redraw of
the compositor.
On 2014/08/23 00:47:11, Ted C wrote:
> Hmm...I would phrase this more as:
> 
> "Trigger a redraw of the compositor.  <Warning that it is only needed if the
UI
> changes something that will not trigger the redraw itself>."

Done.

[no sievers, 2014-08-25 17:40:26]

On 2014/08/25 17:30:05, David Trainor wrote:
>
https://codereview.chromium.org/504553002/diff/1/content/browser/android/cont...
> File content/browser/android/content_view_render_view.cc (right):
> 
>
https://codereview.chromium.org/504553002/diff/1/content/browser/android/cont...
> content/browser/android/content_view_render_view.cc:123:
SetNeedsComposite(env,
> obj);
> On 2014/08/25 17:20:42, sievers wrote:
> > On 2014/08/23 00:47:11, Ted C wrote:
> > > was this missing from before?
> > 
> > am also wondering why this is needed
> 
> I saw we had this in CompositorView and assumed us not having it here was a
bug.
>  SetHasTransparentBackground doesn't seem to trigger any invalidate on the
> LayerTreeHost, so I assumed that was why we had it in CompositorView
downstream.
> 

Ok maybe it's needed then if that doesn't trigger an invalidation.
Sounds good to have it match CompositorView either way.


> If you would like I can remove it until we see if it is an issue.  I imagine
> frames from the renderer probably hide any bugs missing this might cause.
> 
>
https://codereview.chromium.org/504553002/diff/1/content/public/android/java/...
> File
>
content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java
> (right):
> 
>
https://codereview.chromium.org/504553002/diff/1/content/public/android/java/...
>
content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java:151:
> * This method should only be called if something in the UI requires a redraw
of
> the compositor.
> On 2014/08/23 00:47:11, Ted C wrote:
> > Hmm...I would phrase this more as:
> > 
> > "Trigger a redraw of the compositor.  <Warning that it is only needed if the
> UI
> > changes something that will not trigger the redraw itself>."
> 
> Done.

[David Trainor- moved to gerrit, 2014-08-26 20:13:00]

The CQ bit was checked by dtrainor@chromium.org

[commit-bot: I haz the power, 2014-08-26 20:14:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dtrainor@chromium.org/504553002/60001

[commit-bot: I haz the power, 2014-08-26 21:15:33]

Committed patchset #4 (60001) as 83807735609b83ef61fec3609b07cc82d8290812

[commit-bot: I haz the power, 2014-09-10 02:45:38]

Patchset 4 (id:??) landed as
https://crrev.com/e3ed0e0a71cff087bb2a9a082c16ca3617966d7c
Cr-Commit-Position: refs/heads/master@{#291982}