Issue 504473002: Sometimes options won't have a 'shallow' field. Don't freak out.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 504473002: Sometimes options won't have a 'shallow' field. Don't freak out. (Closed)

Created:
6 years, 4 months ago by szager1

Modified:
6 years, 4 months ago

Reviewers:
Vadim Sh., ghost stip (do not use)

CC:
chromium-reviews, cmp-cc_chromium.org, Dirk Pranke, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Project:
tools

Visibility:
Public.

More Reviews

Description

Sometimes options won't have a 'shallow' field. Don't freak out. BUG=406535 R=stip@chromium.org,vadimsh@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291502

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	gclient_scm.py	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/504473002/1

6 years, 4 months ago (2014-08-22 20:58:23 UTC) #4

ghost stip (do not use)

https://codereview.chromium.org/504473002/diff/1/gclient_scm.py File gclient_scm.py (left): https://codereview.chromium.org/504473002/diff/1/gclient_scm.py#oldcode799 gclient_scm.py:799: if options.shallow: doesn't options default to None? or is ...

6 years, 4 months ago (2014-08-22 20:59:02 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (1) as 291502

Expand Messages | Collapse Messages