[Findit] Improve output format and cherry-pick bugs fix.

tools/findit/crash_utils.py

 # Copyright (c) 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import cgi
 import ConfigParser
 import json
 import os
 import time
 
@@ skipping 90 matching lines @@
     path: A string representing a path.
     parsed_deps: A map from component path to its component name, repository,
                  etc.
 
   Returns:
     A tuple containing a component this path is in (e.g blink, skia, etc)
     and a path in that component's repository. Returns None if the component
     repository is not supported, i.e from googlecode.
   """
   # First normalize the path by retreiving the normalized path.
-  normalized_path = os.path.normpath(path.replace('\\', '/'))
+  normalized_path = os.path.normpath(path).replace('\\', '/')
 
   # Iterate through all component paths in the parsed DEPS, in the decreasing
   # order of the length of the file path.
   for component_path in sorted(parsed_deps,
                                key=(lambda path: -len(path))):
     # new_component_path is the component path with 'src/' removed.
     new_component_path = component_path
     if new_component_path.startswith('src/') and new_component_path != 'src/':
       new_component_path = new_component_path[len('src/'):]
 
@@ skipping 101 matching lines @@
     timeout: Time in seconds to wait before time out.
 
   Returns:
     None if the data retrieval fails, or the raw data.
   """
   count = 0
   while True:
     count += 1
     # Retrieves data from URL.
     try:
-      _, data = utils.GetHttpClient().Get(url, timeout=timeout)
+      status_code, data = utils.GetHttpClient().Get(url, timeout=timeout)
+    except IOError:
+      status_code = -1
+      data = None
+
+    if status_code == 200:
       return data
-    except IOError:
-      if count < retries:
-        # If retrieval fails, try after sleep_time second.
-        time.sleep(sleep_time)
-      else:
-        break
+
+    if count < retries:
+      # If retrieval fails, try after sleep_time second.
+      time.sleep(sleep_time)
+    else:
+      break
 
   # Return None if it fails to read data from URL 'retries' times.
   return None
 
 
 def FindMinLineDistance(crashed_line_list, changed_line_numbers,
                         line_range=3):
   """Calculates how far the changed line is from one of the crashes.
 
   Finds the minimum distance between the lines that the file crashed on
@@ skipping 91 matching lines @@
     link: A link to add to the string.
 
   Returns:
     A string with hyperlink added.
   """
   sanitized_link = cgi.escape(link, quote=True)
   sanitized_text = cgi.escape(str(text))
   return '<a href="%s">%s</a>' % (sanitized_link, sanitized_text)
 
 
-def PrettifyList(l):
+def PrettifyList(items):
   """Returns a string representation of a list.
 
   It adds comma in between the elements and removes the brackets.
   Args:
-    l: A list to prettify.
+    items: A list to prettify.
   Returns:
     A string representation of the list.
   """
-  return str(l)[1:-1]
+  return ', '.join(map(str, items))
+
+
+def PrettifyFrameInfo(frame_indices, functions):
+  """Return a string to represent the frames with functions."""
+  frames = []
+  for frame_index, function in zip(frame_indices, functions):
+    frames.append('frame #%s, function "%s"' % (frame_index, function))
+  return '; '.join(frames)
 
 
 def PrettifyFiles(file_list):
   """Returns a string representation of a list of file names.
 
   Args:
     file_list: A list of tuple, (file_name, file_url).
   Returns:
     A string representation of file names with their urls.
   """
@@ skipping 117 matching lines @@
     review_url = None
     reviewers = None
     line_content = blame.line_content
     message = blame.message
 
     result = Result(suspected_cl, revision_url, component_name, author, reason,
                     review_url, reviewers, line_content, message)
     result_list.append(result)
 
   return result_list