Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 504443002: Update mojo surfaces bindings and mojo/cc/ glue (Closed)

Created:
6 years, 4 months ago by jamesr
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Project:
chromium
Visibility:
Public.

Description

Update mojo surfaces bindings and mojo/cc/ glue This provides a SurfacesService that can provide SurfacePtr and id namespaces in one call, since both are needed to do anything useful. This also updates the mojo/cc/ bindings to get closer to binding a cc using client (like html_viewer) with surfaces, although it's not 100% there. R=sky@chromium.org Committed: https://crrev.com/3a29ee299da15e9cd97edf3cf84dc32602a5854f Cr-Commit-Position: refs/heads/master@{#291759}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : gn fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -45 lines) Patch
M mojo/cc/BUILD.gn View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/cc/context_provider_mojo.h View 1 chunk +2 lines, -0 lines 0 comments Download
A mojo/cc/output_surface_mojo.h View 1 1 chunk +38 lines, -0 lines 0 comments Download
A mojo/cc/output_surface_mojo.cc View 1 1 chunk +49 lines, -0 lines 0 comments Download
M mojo/examples/surfaces_app/child_gl_app.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M mojo/examples/surfaces_app/child_gl_impl.h View 5 chunks +5 lines, -1 line 0 comments Download
M mojo/examples/surfaces_app/child_gl_impl.cc View 1 2 chunks +12 lines, -8 lines 0 comments Download
M mojo/examples/surfaces_app/child_impl.h View 3 chunks +5 lines, -1 line 0 comments Download
M mojo/examples/surfaces_app/child_impl.cc View 1 2 chunks +11 lines, -5 lines 0 comments Download
M mojo/examples/surfaces_app/surfaces_app.cc View 6 chunks +13 lines, -7 lines 0 comments Download
M mojo/mojo.gyp View 1 1 chunk +9 lines, -0 lines 0 comments Download
M mojo/mojo_services.gypi View 1 2 chunks +4 lines, -1 line 0 comments Download
M mojo/services/public/interfaces/surfaces/BUILD.gn View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/services/public/interfaces/surfaces/surfaces.mojom View 1 chunk +4 lines, -1 line 0 comments Download
A mojo/services/public/interfaces/surfaces/surfaces_service.mojom View 1 chunk +15 lines, -0 lines 0 comments Download
M mojo/services/surfaces/surfaces_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/services/surfaces/surfaces_impl.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/services/surfaces/surfaces_service_application.h View 2 chunks +5 lines, -3 lines 0 comments Download
M mojo/services/surfaces/surfaces_service_application.cc View 2 chunks +5 lines, -3 lines 0 comments Download
A mojo/services/surfaces/surfaces_service_impl.h View 1 1 chunk +41 lines, -0 lines 0 comments Download
A mojo/services/surfaces/surfaces_service_impl.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M mojo/shell/in_process_dynamic_service_runner.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
jamesr
This isn't everything but it gets the surfaces examples going again and gets closer to ...
6 years, 4 months ago (2014-08-22 19:15:38 UTC) #1
sky
LGTM https://codereview.chromium.org/504443002/diff/1/mojo/cc/output_surface_mojo.cc File mojo/cc/output_surface_mojo.cc (right): https://codereview.chromium.org/504443002/diff/1/mojo/cc/output_surface_mojo.cc#newcode48 mojo/cc/output_surface_mojo.cc:48: } nit: newline between 47/48 and // namespace ...
6 years, 4 months ago (2014-08-22 22:20:09 UTC) #2
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-25 19:37:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/504443002/20001
6 years, 4 months ago (2014-08-25 19:38:24 UTC) #4
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 4 months ago (2014-08-25 19:43:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/504443002/40001
6 years, 4 months ago (2014-08-25 19:43:50 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (40001) as 4626919098f323e83ac8edb38f9c9b9a9e8946e2
6 years, 3 months ago (2014-08-25 20:54:21 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:37:30 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/3a29ee299da15e9cd97edf3cf84dc32602a5854f
Cr-Commit-Position: refs/heads/master@{#291759}

Powered by Google App Engine
This is Rietveld 408576698