Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 504423002: Fix saveLayer() with a pixel-moving filter vs SkBBoxHierarchyRecord / SkRecordDraw (Closed)

Created:
6 years, 3 months ago by Stephen White
Modified:
6 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@m38_2125
Project:
skia
Visibility:
Public.

Description

Fix saveLayer() with a pixel-moving filter vs SkBBoxHierarchyRecord / SkRecordDraw In SkBBoxHierarchyRecord: Since the bounds we pass to saveLayer are in the pre-filtering coordinate space, they aren't correct for determining the actual device pixels touched by the saveLayer in this case. The easiest fix for now is to pass the clip bounds, since the final draw done in restore() will never draw outside the clip. In SkRecordDraw: We do adjust the bounds passed to saveLayer, so we just need to make sure that when we're using a paint that may affect transparent black, we ignore the calculated bounds of draw ops and use the clip intersected with those adjusted bounds. See originally crrev.com/497773002 BUG=skia: R=reed@google.com, senorblanco@chromium.org, junov@chromium.org, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/496963003 (cherry picked from commit d910f544439fffa6c2bcc5181b79b2811a4c130a) Committed: https://skia.googlesource.com/skia/+/749e42a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -11 lines) Patch
M src/core/SkBBoxHierarchyRecord.cpp View 1 chunk +3 lines, -8 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 1 chunk +13 lines, -3 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Stephen White
6 years, 3 months ago (2014-08-26 21:31:08 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as 749e42a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698