Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 504393002: Switch GPU Optimization code to SkRecord (Closed)

Created:
6 years, 3 months ago by robertphillips
Modified:
6 years, 3 months ago
Reviewers:
mtklein, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Switch GPU Optimization code to SkRecord Committed: https://skia.googlesource.com/skia/+/d62833079fc36e28e65692f9a0c7dbdb124519c6

Patch Set 1 #

Patch Set 2 : Clean up #

Patch Set 3 : Clean up #

Total comments: 2

Patch Set 4 : Address code review issue #

Patch Set 5 : Update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -269 lines) Patch
M include/core/SkPicture.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPictureUtils.h View 2 chunks +6 lines, -3 lines 0 comments Download
M src/gpu/GrPictureUtils.cpp View 1 2 3 2 chunks +217 lines, -219 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 4 3 chunks +6 lines, -10 lines 0 comments Download
M tests/PictureTest.cpp View 1 2 3 4 4 chunks +104 lines, -36 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
robertphillips
robertphillips@google.com changed reviewers: + bsalomon@google.com, mtklein@google.com
6 years, 3 months ago (2014-08-27 15:40:14 UTC) #1
robertphillips
6 years, 3 months ago (2014-08-27 15:48:20 UTC) #2
bsalomon
lgtm
6 years, 3 months ago (2014-08-27 16:14:21 UTC) #3
mtklein
lgtm Looks veeeery familiar. :) Will probably try to merge some of this with the ...
6 years, 3 months ago (2014-08-27 16:20:59 UTC) #4
robertphillips
https://codereview.chromium.org/504393002/diff/40001/src/gpu/GrPictureUtils.cpp File src/gpu/GrPictureUtils.cpp (right): https://codereview.chromium.org/504393002/diff/40001/src/gpu/GrPictureUtils.cpp#newcode173 src/gpu/GrPictureUtils.cpp:173: return; On 2014/08/27 16:20:59, mtklein wrote: > Also SkASSERT(false)? ...
6 years, 3 months ago (2014-08-27 16:25:51 UTC) #5
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 3 months ago (2014-08-27 16:25:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/504393002/60001
6 years, 3 months ago (2014-08-27 16:26:19 UTC) #7
robertphillips
The CQ bit was unchecked by robertphillips@google.com
6 years, 3 months ago (2014-08-27 17:48:58 UTC) #8
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 3 months ago (2014-08-27 17:50:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/504393002/80001
6 years, 3 months ago (2014-08-27 17:50:42 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-08-27 18:53:33 UTC) #11
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as d62833079fc36e28e65692f9a0c7dbdb124519c6

Powered by Google App Engine
This is Rietveld 408576698