Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 504343007: DirectWrite to use aliased if ClearType is empty. (Closed)

Created:
4 years, 8 months ago by bungeman-skia
Modified:
4 years, 8 months ago
CC:
reviews_skia.org, kareng
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

DirectWrite to use aliased if ClearType is empty. Some CJK fonts with some versions of DirectWrite return valid data for bitmaps, but not for cleartype data. For reference, two screenshots. M37 Stable and then with this patch: http://imgur.com/9pf3rB9,EiTb6Li See https://code.google.com/p/chromium/issues/detail?id=396624#c10 for content of test html file. R=eae@chromium.org, reed@google.com, shrikant@chromium.org, bungeman@chromium.org, cpu@chromium.org BUG=chromium:407945 Committed: https://skia.googlesource.com/skia/+/b2f7fce

Patch Set 1 #

Total comments: 1

Patch Set 2 : Per glyph. #

Total comments: 1

Patch Set 3 : Add comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -15 lines) Patch
M src/core/SkGlyph.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/ports/SkScalerContext_win_dw.h View 1 1 chunk +8 lines, -1 line 0 comments Download
M src/ports/SkScalerContext_win_dw.cpp View 1 2 7 chunks +48 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
bungeman-skia
A somewhat cleaner version of https://codereview.chromium.org/510563003/ .
4 years, 8 months ago (2014-08-27 21:58:16 UTC) #1
eae
LGTM Thanks Ben!
4 years, 8 months ago (2014-08-27 22:03:41 UTC) #2
reed1
reed@google.com changed reviewers: + reed@google.com
4 years, 8 months ago (2014-08-27 22:07:33 UTC) #3
reed1
https://codereview.chromium.org/504343007/diff/1/src/ports/SkScalerContext_win_dw.cpp File src/ports/SkScalerContext_win_dw.cpp (right): https://codereview.chromium.org/504343007/diff/1/src/ports/SkScalerContext_win_dw.cpp#newcode458 src/ports/SkScalerContext_win_dw.cpp:458: if (bbox.left != bbox.right && bbox.top != bbox.bottom) { ...
4 years, 8 months ago (2014-08-27 22:07:33 UTC) #4
reed1
seems very readable. lgtm (assuming it works) https://codereview.chromium.org/504343007/diff/20001/src/ports/SkScalerContext_win_dw.cpp File src/ports/SkScalerContext_win_dw.cpp (right): https://codereview.chromium.org/504343007/diff/20001/src/ports/SkScalerContext_win_dw.cpp#newcode458 src/ports/SkScalerContext_win_dw.cpp:458: if (bbox.left ...
4 years, 8 months ago (2014-08-27 22:46:54 UTC) #5
reed1
4 years, 8 months ago (2014-08-27 22:50:56 UTC) #6
scottmg
Confirmed fixes the repro I had. LGTM, thanks. Result here: http://imgur.com/GOFQh2s (text after Japanese text ...
4 years, 8 months ago (2014-08-27 23:10:07 UTC) #7
Shrikant Kelkar
On 2014/08/27 23:10:07, scottmg wrote: > Confirmed fixes the repro I had. LGTM, thanks. > ...
4 years, 8 months ago (2014-08-27 23:11:37 UTC) #8
bungeman-skia
4 years, 8 months ago (2014-08-27 23:18:50 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as b2f7fce.

Powered by Google App Engine
This is Rietveld 408576698