Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 504343005: Slightly simplify Math.sign and Math.trunc. (Closed)

Created:
6 years, 3 months ago by Yang
Modified:
6 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Slightly simplify Math.sign and Math.trunc. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23440

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/math.js View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 3 months ago (2014-08-27 07:01:38 UTC) #1
Sven Panne
lgtm
6 years, 3 months ago (2014-08-27 07:40:55 UTC) #2
Yang
6 years, 3 months ago (2014-08-27 09:49:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23440 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698