Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 504333003: [telemetry] Use SetEvent signals instead of web server for IPPET power monitor. (Closed)

Created:
6 years, 3 months ago by dtu
Modified:
6 years, 3 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[telemetry] Use SetEvent signals instead of web server for IPPET power monitor. Hopefully this will reduce flake and overhead from running the web server. BUG=336558 TEST=Enable IppetPowerMonitor.CanMonitorPower(), then tools/telemetry/run_tests ippet on Windows. Committed: https://crrev.com/cb25fdedc138dcfd72f2293553a7d9616ff6396f Cr-Commit-Position: refs/heads/master@{#292093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -35 lines) Patch
M tools/telemetry/telemetry/core/platform/power_monitor/ippet_power_monitor.py View 4 chunks +46 lines, -35 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dtu
dtu@chromium.org changed reviewers: + tonyg@chromium.org
6 years, 3 months ago (2014-08-27 00:56:28 UTC) #1
dtu
6 years, 3 months ago (2014-08-27 00:56:28 UTC) #2
tonyg
lgtm woot :) Any idea what the cycle time is like w/ this patch?
6 years, 3 months ago (2014-08-27 01:00:09 UTC) #3
dtu
On 2014/08/27 01:00:09, tonyg wrote: > lgtm > > woot :) > > Any idea ...
6 years, 3 months ago (2014-08-27 01:02:21 UTC) #4
dtu
The CQ bit was checked by dtu@chromium.org
6 years, 3 months ago (2014-08-27 01:14:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/504333003/1
6 years, 3 months ago (2014-08-27 01:15:25 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-27 03:13:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (1) as ad9843c5ebf548e649dc635099145744a1137dfa
6 years, 3 months ago (2014-08-27 03:55:26 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:49:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb25fdedc138dcfd72f2293553a7d9616ff6396f
Cr-Commit-Position: refs/heads/master@{#292093}

Powered by Google App Engine
This is Rietveld 408576698