Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1345)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 50433008: Dispatch browser action clicks to the profile for the browser window. (Closed)

Created:
7 years, 1 month ago by Yoyo Zhou
Modified:
7 years, 1 month ago
Reviewers:
Matt Perry
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Dispatch browser action clicks to the profile for the browser window. This fixes a bug where incognito split mode extensions were getting clicks from incognito browsers sent to the regular profile. BUG=314142 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232968

Patch Set 1 #

Patch Set 2 : neater test #

Patch Set 3 : (c) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -1 line) Patch
M chrome/browser/extensions/api/extension_action/browser_action_apitest.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/test/data/extensions/api_test/browser_action/split_mode/background.js View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/browser_action/split_mode/manifest.json View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Yoyo Zhou
7 years, 1 month ago (2013-11-01 21:46:27 UTC) #1
Matt Perry
lgtm
7 years, 1 month ago (2013-11-01 21:48:31 UTC) #2
Yoyo Zhou
P.S. I fixed the test slightly so that it runs in the tabs.create callback.
7 years, 1 month ago (2013-11-01 21:51:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/50433008/50001
7 years, 1 month ago (2013-11-01 22:13:51 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=34047
7 years, 1 month ago (2013-11-01 23:10:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/50433008/140001
7 years, 1 month ago (2013-11-01 23:36:20 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=217918
7 years, 1 month ago (2013-11-02 02:55:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/50433008/140001
7 years, 1 month ago (2013-11-04 18:59:02 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=218811
7 years, 1 month ago (2013-11-05 00:42:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/50433008/140001
7 years, 1 month ago (2013-11-05 00:55:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/50433008/140001
7 years, 1 month ago (2013-11-05 03:07:21 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=219422
7 years, 1 month ago (2013-11-05 08:10:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/50433008/140001
7 years, 1 month ago (2013-11-05 08:12:48 UTC) #13
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 13:55:25 UTC) #14
Message was sent while issue was closed. 
Change committed as 232968

Powered by Google App Engine
This is Rietveld 408576698