Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(631)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: LayoutTests/editing/selection/drag-selection-nodes-expected.txt
Issue
50433002
:
Fix dragging text inside a input element nested in a draggable element. (Closed)
Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Some layout tests
Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
LayoutTests/editing/selection/drag-input-text-nested-in-draggable-element.html
LayoutTests/editing/selection/drag-input-text-nested-in-draggable-element-expected.txt
LayoutTests/editing/selection/drag-selection-nodes.html
LayoutTests/editing/selection/drag-selection-nodes-expected.txt
Source/core/page/DragActions.h
Source/core/page/DragController.h
Source/core/page/DragController.cpp
Source/core/page/EventHandler.h
Source/core/page/EventHandler.cpp
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« no previous file with comments
|
« LayoutTests/editing/selection/drag-selection-nodes.html
('k') |
Source/core/page/DragActions.h »
('j') |
Source/core/page/DragController.cpp »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
Simple test that dragging and dropping a selection targets the right node.
2
3
Test 1: select this line and drag me.
4
Test 2:
5
6
Test 3: select this line and drag me from the image.
7
Test 1: FAIL: target element was [object HTMLDivElement]
8
Test 2: PASS
9
Test 3: PASS
OLD
NEW
« no previous file with comments
|
« LayoutTests/editing/selection/drag-selection-nodes.html
('k') |
Source/core/page/DragActions.h »
('j') |
Source/core/page/DragController.cpp »
('J')
Issue 50433002: Fix dragging text inside a input element nested in a draggable element. (Closed)
Created 7 years, 1 month ago by dcheng
Modified 7 years, 1 month ago
Reviewers: tony
Base URL: svn://svn.chromium.org/blink/trunk
Comments: 4
This is Rietveld
408576698