Remove implicit conversions from scoped_refptr to T* in chrome/browser/sync/

chrome/browser/sync/profile_sync_components_factory_impl.cc

Index: chrome/browser/sync/profile_sync_components_factory_impl.cc
diff --git a/chrome/browser/sync/profile_sync_components_factory_impl.cc b/chrome/browser/sync/profile_sync_components_factory_impl.cc
index aa16e7eefa68d5ac2780a129d785b2e295fbcf56..25a8ffe83dff8a05d7b4bdfaa34475b902f4daec 100644
--- a/chrome/browser/sync/profile_sync_components_factory_impl.cc
+++ b/chrome/browser/sync/profile_sync_components_factory_impl.cc
@@ -531,7 +531,7 @@ base::WeakPtr<syncer::SyncableService> ProfileSyncComponentsFactoryImpl::
     }
     case syncer::PASSWORDS: {
 #if defined(PASSWORD_MANAGER_ENABLE_SYNC)
-      password_manager::PasswordStore* password_store =
+      scoped_refptr<password_manager::PasswordStore> password_store =

[dcheng, 2014/08/26 18:40:57]

Strictly speaking, this seems like an unnecessary conversion. The tool made this
rewrite though, because in general, it's not safe to convert a temporary
scoped_refptr to a raw pointer. Please let me know if you'd like me to revert
the variable type change here.

[Nicolas Zea, 2014/08/26 23:31:37]

This seems fine, although I would have expected the tool to conver the
password_store turnary three lines below into a password_store.get() (or
possible a !!password_store.get()).

[dcheng, 2014/08/26 23:34:54]

Oops. Fixed. The tool is single-pass, I usually scan CLs for instances where
types were rewritten and then run the tool again--but I missed this one. Thanks
for the catch.

           PasswordStoreFactory::GetForProfile(profile_,
                                               Profile::EXPLICIT_ACCESS);
       return password_store ? password_store->GetPasswordSyncableService()