Issue 504263002: Add DebugInfo to DistilledPageProto.

Issue 504263002: Add DebugInfo to DistilledPageProto. (Closed)

Created:
6 years, 3 months ago by nyquist

Modified:
6 years, 3 months ago

Reviewers:
cjhopman

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@remove-intermediate-distilledpageinfo-structs

Project:
chromium

Visibility:
Public.

Add DebugInfo to DistilledPageProto. Adds a DebugInfo message to the DistilledPageProto. The data for this message is copied from the DomDistillerResult proto DebugInfo. For now, only a field for the distiller log exists. Depends on https://codereview.chromium.org/493853006/ BUG=409274 Committed: https://crrev.com/3d377a4a08d8be39211dd63ec61ea8ff5643df37 Cr-Commit-Position: refs/heads/master@{#293205}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -1 line)			Patch
M	components/dom_distiller/core/distiller.cc	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	components/dom_distiller/core/distiller_unittest.cc	View	1	2 chunks	+15 lines, -0 lines	0 comments	Download
M	components/dom_distiller/core/proto/distilled_page.proto	View		1 chunk	+9 lines, -1 line	0 comments	Download
M	components/dom_distiller/standalone/content_extractor.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 7 (1 generated)

nyquist

nyquist@chromium.org changed reviewers: + cjhopman@chromium.org

6 years, 3 months ago (2014-08-28 21:33:33 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/504263002/60001

6 years, 3 months ago (2014-09-03 18:27:14 UTC) #5

commit-bot: I haz the power

Committed patchset #4 (id:60001) as db48b51a5578774f66c5e901fb02e062127dda38

6 years, 3 months ago (2014-09-03 21:49:15 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:28:03 UTC) #7

Message was sent while issue was closed.

Patchset 4 (id:??) landed as
https://crrev.com/3d377a4a08d8be39211dd63ec61ea8ff5643df37
Cr-Commit-Position: refs/heads/master@{#293205}